public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH docs 1/3] docs: explain the working principle of the change detection modes
Date: Tue, 26 Nov 2024 10:45:28 +0100	[thread overview]
Message-ID: <ea7d6a8e-f432-4d98-8d34-795a436343ae@proxmox.com> (raw)
In-Reply-To: <5990610f-700c-45ed-b47c-06e214abc918@proxmox.com>

On 11/26/24 10:22, Thomas Lamprecht wrote:
> Am 26.11.24 um 08:29 schrieb Christian Ebner:
>> On 11/25/24 22:09, Thomas Lamprecht wrote:
>> Okay, will also add a short note that since the legacy mode and the two
>> other modes use different archive formats, they do not reuse chunks as
>> efficiently when using mixed modes on the same datastore.
> 
> Fine I guess, but this wasn't really what I had in mind here, and I would
> not "bad-mouth" your nice work here too much hehe.

Well, no intention in bad mouthing it ;)

Nevertheless, I would not refrain from mentioning this as there was some 
feedback regarding increased size usage after switching modes (cannot 
find the relevant forum thread at the moment). So letting users know 
that they might take a closer look at the datastore disk usage after 
switching to one of the new modes can only help.

> In the forum there was just some confusion about three change-modes maybe
> meaning three formats. I.e., more that the data one replaces the legacy one
> with the benefit of being able to seamlessly switch to metadata mode and back
> again, as both use the same archive format/structure.
> 
>>> This mail is inspired a bit from the post I replied here:
>>>
>>> https://forum.proxmox.com/threads/proxmox-ve-8-3-released.157793/page-2#post-723212
> 
> ^- if my reply was (hopefully) somewhat clear maybe something of it can be
> used as base.
> 

I did already send a patch [0], but only loosely followed your reply in 
the forum thread. Maybe we can improve based on that?

[0] 
https://lore.proxmox.com/pbs-devel/20241126085502.77438-1-c.ebner@proxmox.com/T/#u



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2024-11-26  9:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18  9:24 [pbs-devel] [PATCH docs 0/3] extend documentation for change detection mode Christian Ebner
2024-11-18  9:24 ` [pbs-devel] [PATCH docs 1/3] docs: explain the working principle of the change detection modes Christian Ebner
2024-11-25 21:09   ` Thomas Lamprecht
2024-11-26  7:29     ` Christian Ebner
2024-11-26  9:22       ` Thomas Lamprecht
2024-11-26  9:45         ` Christian Ebner [this message]
2024-11-18  9:24 ` [pbs-devel] [PATCH docs 2/3] docs: reference technical change detection mode section for client Christian Ebner
2024-11-18  9:24 ` [pbs-devel] [PATCH docs 3/3] docs: client: fix formatting by using double ticks Christian Ebner
2024-11-18 15:04   ` Shannon Sterz
2024-11-21 16:04 ` [pbs-devel] applied-series: [PATCH docs 0/3] extend documentation for change detection mode Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea7d6a8e-f432-4d98-8d34-795a436343ae@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal