Re: [pbs-devel] [PATCH proxmox-backup] api: backup: use configured verify thread counts for 'verify-new'

[Christian Ebner <c.ebner@proxmox.com>]

On 1/20/26 12:33 PM, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>   src/api2/backup/environment.rs | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs
> index bd9c5211..3c624b18 100644
> --- a/src/api2/backup/environment.rs
> +++ b/src/api2/backup/environment.rs
> @@ -799,10 +799,13 @@ impl BackupEnvironment {
>               false,
>               move |worker| {
>                   worker.log_message("Automatically verifying newly added snapshot");
> -
> -                // FIXME: update once per-datastore read/verify settings
> -                // are available to not use default amount of threads here
> -                let verify_worker = VerifyWorker::new(worker.clone(), datastore, None, None)?;
> +                let thread_settings = datastore.thread_settings().clone();
> +                let verify_worker = VerifyWorker::new(
> +                    worker.clone(),
> +                    datastore,
> +                    thread_settings.verify_job_read_threads,
> +                    thread_settings.verify_job_verify_threads,
> +                )?;
>                   if !verify_worker.verify_backup_dir_with_lock(
>                       &backup_dir,
>                       worker.upid().clone(),

I don't think this is necessary. VerifyWorker::new() already reads the 
datastore's verify thread settings if no custom (per-worker) values are 
passed in as parameters and falls back to the global defaults if none 
are set for the datastore.

So the only thing to be done is drop the outdated FIXME comment and 
maybe improve the logging of the parameters being used if non-default, 
including which setting has been applied (global, datastore, job/cli 
invokation).