From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Max Carrara <m.carrara@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5217: api: send missing header when upgrading to HTTP/2
Date: Wed, 28 Feb 2024 19:03:04 +0100 [thread overview]
Message-ID: <e9af7136-e5ff-4190-8d5f-eebe6030da73@proxmox.com> (raw)
In-Reply-To: <20240228162059.426638-1-m.carrara@proxmox.com>
Am 28/02/2024 um 17:20 schrieb Max Carrara:
> Caddy therefore does not deviate from the HTTP/1.1 and HTTP/2
> specifications; neither to we. I therefore conclude that it's best to
> just include the header in this specific response anyway, as no harm
> is done by doing so.
>
can be fine, but is there any discussion about this from Caddy's site?
As while we can take this in and PBS should work with Caddy in-between,
other HTTP/2 daemons that follow spec while not having that header
still won't work.
So, if there isn't any issue tracker entry for this at caddy's side it
might be worth opening one even if we apply this here, and if there's
an existing issue then referencing it here would be great.
next prev parent reply other threads:[~2024-02-28 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 16:20 Max Carrara
2024-02-28 18:03 ` Thomas Lamprecht [this message]
2024-02-29 15:26 ` Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9af7136-e5ff-4190-8d5f-eebe6030da73@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox