From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] pbs-datastore: use ConfigVersionCache for datastore
Date: Tue, 1 Mar 2022 09:53:01 +0100 [thread overview]
Message-ID: <e991ba2c-a922-f905-fa55-0122167f5781@proxmox.com> (raw)
In-Reply-To: <fe1bef24-ac58-56a3-9768-672b26492c3b@proxmox.com>
On 28.02.22 07:51, Dominik Csapak wrote:
> On 2/25/22 16:25, Dietmar Maurer wrote:
>>> but on the other hand, we now basically create a new datastore object
>>> every minute
>>
>> And you think this is a problem (why)?
>
> it seems unnecessary, and if it was not a problem, why didn't we do it before?
> we already read/parsed the config anyway....
>
> i assumed that there was a good reason not to construct a new object
> every time, but i did not find it
>
Yeah I also do not get this, especially as there's zero info about "why"
and the benefits in the commit message - that's more important than
describing the diff that is attached to the commit anyway (not that this
cannot help but focus should be on the former).
Any benchmarking, timing assumptions or other things done? As more and
more complex code should have /some/ arguing in favor of it sent along..
next prev parent reply other threads:[~2022-03-01 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 15:25 Dietmar Maurer
2022-02-28 6:51 ` Dominik Csapak
2022-03-01 8:53 ` Thomas Lamprecht [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-25 14:26 Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e991ba2c-a922-f905-fa55-0122167f5781@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox