From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] ui: add 'show repository Information' button for datastores
Date: Wed, 29 Nov 2023 15:53:27 +0100 [thread overview]
Message-ID: <e8f55b44-c28e-481e-ac55-ea6554ebb391@proxmox.com> (raw)
In-Reply-To: <20231129110309.2524356-1-d.csapak@proxmox.com>
Am 29/11/2023 um 12:03 schrieb Dominik Csapak:
> this has a similar functionality as the 'show fingerprint' button,
> but for repository strings that are needed e.g. for the cli
>
> included with and without the current user for convenience
>
datastore should be copyable too, and could be nice if the host (ip or domain,
maybe just document.location.hostname) would be visble separately too.
Potentially divide the repo stuff for CLI a bit of with a extra line that
spots a "Repository for CLI and API" label (or the like)
W.r.t. button placement, to the contrary of my intial suggestion I might
prefer it at the start of the summary view's top bar (where the RRD range
selector is). similar to the "Package Versions" button in PVE's node
summary.
An onlineHelp reference to "Backup Repository Locations" as Fabian suggests
would be really a good idea, as is the missing padding for the copy buttons,
and those could be a bit less flashy by using the inline buttons (or toolbar
button, always forget what we/ExtJS name it) styling.
next prev parent reply other threads:[~2023-11-29 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 11:03 Dominik Csapak
2023-11-29 11:03 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: add fingerprint also to the 'show repository information' window Dominik Csapak
2023-11-29 14:14 ` [pbs-devel] [PATCH proxmox-backup 1/2] ui: add 'show repository Information' button for datastores Fabian Grünbichler
2023-11-29 14:53 ` Thomas Lamprecht [this message]
2023-11-29 14:59 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8f55b44-c28e-481e-ac55-ea6554ebb391@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox