From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox 1/2] http: factor out PBS shared rate limiter implementation
Date: Mon, 15 Sep 2025 21:10:18 +0200 [thread overview]
Message-ID: <e8a9e8c6-bbf5-4ca0-9bf2-20c851490e29@proxmox.com> (raw)
In-Reply-To: <20250828102604.463662-2-c.ebner@proxmox.com>
Am 28.08.25 um 12:26 schrieb Christian Ebner:
> Moves the current shared rate limiter implementation from the Proxmox
> Backup Server into proxmox-http for it to be reusable, e.g. for s3
> client rate limiting.
Two things:
1. There is still the PROXMOX_BACKUP_SHARED_RATE_LIMITER_MAGIC_1_0 references
to PBS that should be made generic in naming, otherwise it might be confusing.
2. Should the this and the existing RateLimiter go into their own crate? They
are not really tied to being used with HTTP after all, token bucket filter
are a rather generic concept and besides the central module entry point lib.rs
you do not touch any file from the crate here. What do you think?
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-09-15 19:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 10:25 [pbs-devel] [PATCH proxmox{, -backup} 0/6] shared rate limiter for s3 client instances Christian Ebner
2025-08-28 10:25 ` [pbs-devel] [PATCH proxmox 1/2] http: factor out PBS shared rate limiter implementation Christian Ebner
2025-09-15 19:10 ` Thomas Lamprecht [this message]
2025-09-16 8:13 ` Christian Ebner
2025-08-28 10:26 ` [pbs-devel] [PATCH proxmox 2/2] s3-client: add shared rate limiter via https connector Christian Ebner
2025-08-28 10:26 ` [pbs-devel] [PATCH proxmox-backup 1/4] traffic control: use factored out shared rate limiter Christian Ebner
2025-08-28 10:26 ` [pbs-devel] [PATCH proxmox-backup 2/4] api: config: update s3 endpoint rate limits in config Christian Ebner
2025-08-28 10:26 ` [pbs-devel] [PATCH proxmox-backup 3/4] datastore: s3: set rate limiter options for s3 client Christian Ebner
2025-08-28 10:26 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: expose rate and burst limits for s3 endpoints Christian Ebner
2025-09-15 12:15 ` [pbs-devel] [PATCH proxmox{, -backup} 0/6] shared rate limiter for s3 client instances Christian Ebner
2025-09-16 12:43 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a9e8c6-bbf5-4ca0-9bf2-20c851490e29@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox