[pbs-devel] [PATCH proxmox-backup 1/1] ui: mask unmounted datastores in datastore overview

[pbs-devel] [PATCH proxmox-backup 1/1] ui: mask unmounted datastores in datastore overview

[Stefan Hanreich]

Currently, showing the Datastore summary page leads to errors since
the status returned by the API does not contain any fields that are
checked by the component rendering the datastore summary. We solve
this by checking if the datastore is currently mounted first and mask
the element if it is currently unmounted.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 www/datastore/DataStoreListSummary.js | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/www/datastore/DataStoreListSummary.js b/www/datastore/DataStoreListSummary.js
index f7ea83e7..b43f1ab2 100644
--- a/www/datastore/DataStoreListSummary.js
+++ b/www/datastore/DataStoreListSummary.js
@@ -35,6 +35,13 @@ Ext.define('PBS.datastore.DataStoreListSummary', {
 	let me = this;
 	let vm = me.getViewModel();
 
+	if (statusData['mount-status'] === 'notmounted') {
+	    let maskMessage = gettext('Datastore is not mounted');
+	    let maskIcon = 'fa pbs-unplugged-mask';
+	    me.mask(maskMessage, maskIcon);
+	    return;
+	}
+
 	if (statusData.error !== undefined) {
 	    Proxmox.Utils.API2Request({
 		url: `/config/datastore/${statusData.store}`,
-- 
2.39.5


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup 1/1] ui: mask unmounted datastores in datastore overview

[Shannon Sterz]

On Thu Nov 28, 2024 at 11:40 AM CET, Stefan Hanreich wrote:
> Currently, showing the Datastore summary page leads to errors since
> the status returned by the API does not contain any fields that are
> checked by the component rendering the datastore summary. We solve
> this by checking if the datastore is currently mounted first and mask
> the element if it is currently unmounted.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  www/datastore/DataStoreListSummary.js | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/www/datastore/DataStoreListSummary.js b/www/datastore/DataStoreListSummary.js
> index f7ea83e7..b43f1ab2 100644
> --- a/www/datastore/DataStoreListSummary.js
> +++ b/www/datastore/DataStoreListSummary.js
> @@ -35,6 +35,13 @@ Ext.define('PBS.datastore.DataStoreListSummary', {
>  	let me = this;
>  	let vm = me.getViewModel();
>
> +	if (statusData['mount-status'] === 'notmounted') {
> +	    let maskMessage = gettext('Datastore is not mounted');
> +	    let maskIcon = 'fa pbs-unplugged-mask';
> +	    me.mask(maskMessage, maskIcon);
> +	    return;
> +	}
> +
>  	if (statusData.error !== undefined) {
>  	    Proxmox.Utils.API2Request({
>  		url: `/config/datastore/${statusData.store}`,

tested this and seems to works as intended (no more error in the
console, datastore is properly masked), so consider this:

Tested-by: Shannon Sterz <s.sterz@proxmox.com>

code also looks fine to me


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup 1/1] ui: mask unmounted datastores in datastore overview

[Stefan Hanreich]

just found something - element doesn't get unmasked if the store gets
mounted while the summary page is open. will send a v2.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel