public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: make prune-group a real workertask
Date: Wed, 24 Jan 2024 14:17:10 +0100	[thread overview]
Message-ID: <e5b268e0-c03a-4196-9ef1-c01380232779@proxmox.com> (raw)
In-Reply-To: <20240124103459.74843-1-g.goller@proxmox.com>

Am 24.01.24 um 11:34 schrieb Gabriel Goller:
> -    Ok(json!(prune_result))

> +    Ok(json!(upid))

That seems like a breaking API change at a first glance and thus has to
wait for the next major release unfortunately.

AFAIU the same rules as for PVE apply, see:
https://pve.proxmox.com/wiki/Proxmox_VE_API#API_Stability_.26_Breakage




  reply	other threads:[~2024-01-24 13:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 10:34 Gabriel Goller
2024-01-24 13:17 ` Fiona Ebner [this message]
2024-01-24 13:28   ` Thomas Lamprecht
2024-01-24 13:42     ` Gabriel Goller
2024-01-25 11:49       ` Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5b268e0-c03a-4196-9ef1-c01380232779@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal