From: Christian Ebner <c.ebner@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox{,-backup} v2 0/3] fixes #7465: add gc-on-unmount flag
Date: Tue, 21 Apr 2026 13:34:28 +0200 [thread overview]
Message-ID: <e57a9f4a-a27a-42fd-9851-a11d948ff65e@proxmox.com> (raw)
In-Reply-To: <20260420074257.9492-1-h.laimer@proxmox.com>
On 4/20/26 9:41 AM, Hannes Laimer wrote:
> So GC can run before unmount, without this its somewhat complicated to
> run gc on a datastore that is configured to auto unmount after jobs
> finish.
>
> v2, thanks @Chris!:
> - include proxmox patch
> - don't lock config for just reading
> - improve comments/commit msg
>
Thanks for addressing the comments from v1:
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
prev parent reply other threads:[~2026-04-21 11:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 7:42 Hannes Laimer
2026-04-20 7:42 ` [PATCH proxmox v2 1/3] pbs-api-types: add gc-on-unmount flag for removable datastores Hannes Laimer
2026-04-21 22:17 ` applied: " Thomas Lamprecht
2026-04-20 7:42 ` [PATCH proxmox-backup v2 2/3] api: datastore: add option to run garbage collection before unmount Hannes Laimer
2026-04-20 8:32 ` Shannon Sterz
2026-04-20 8:45 ` Hannes Laimer
2026-04-20 8:52 ` Shannon Sterz
2026-04-20 7:42 ` [PATCH proxmox-backup v2 3/3] ui: datastore: expose gc-on-unmount setting Hannes Laimer
2026-04-21 11:34 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e57a9f4a-a27a-42fd-9851-a11d948ff65e@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox