From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4466: show snapshots in media content again
Date: Mon, 16 Jan 2023 11:52:09 +0100 [thread overview]
Message-ID: <e33897c2-3d79-499d-8bbb-e71435105ad6@proxmox.com> (raw)
In-Reply-To: <c12e3405-f276-1e14-7c9a-cb00be2d9631@proxmox.com>
On 1/16/23 11:10, Thomas Lamprecht wrote:
> meh got already pushed 1:1, for the record:
>
> misses "tape:" (or "tape inventory:") subsystem tag in subject
>
> Am 16/01/2023 um 09:21 schrieb Dominik Csapak:
>> while refactoring the the empty media set checks, we accidentally
>> reversed one check from !is_empty to unassigned, which now never
>> included the right media sets.
>>
>> reversing the condition fixes that.
>>
>> fixes
>> 52517f7b: ("tape: hide internal use of all zero uuid for unassigned tapes")
>>
>
> Please start trailers with a capital letter and avoid extra newlines, i.e.,
> after "Fixes:" (fine to go over ci message length for trailers) and between
> the S-o-b .
sure no problem, should we include that in the developer docs?
(did not find it there)
>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> src/tape/inventory.rs | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/tape/inventory.rs b/src/tape/inventory.rs
>> index dd560179..1817ab2e 100644
>> --- a/src/tape/inventory.rs
>> +++ b/src/tape/inventory.rs
>> @@ -294,7 +294,7 @@ impl Inventory {
>> match entry.id.media_set_label {
>> None => continue, // not assigned to any pool
>> Some(ref set) => {
>> - if set.unassigned() {
>> + if !set.unassigned() {
>> list.push(entry.id.clone());
>> }
>> }
>
> I pushed out some lightly related clean ups in surrounding code I stumbled
> into when preparing for pushing these, would be great if you could take
> a second look to ensure I didn't overlooked something.
sure i'll take a look
prev parent reply other threads:[~2023-01-16 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 8:21 Dominik Csapak
2023-01-16 9:49 ` [pbs-devel] applied: " Wolfgang Bumiller
2023-01-16 10:10 ` [pbs-devel] " Thomas Lamprecht
2023-01-16 10:52 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e33897c2-3d79-499d-8bbb-e71435105ad6@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox