From: Fabian Ebner <f.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] prune sim: correctly keep track of already included backups
Date: Mon, 14 Dec 2020 16:08:03 +0100 [thread overview]
Message-ID: <e333d53f-ea5a-5b22-b578-e5d556f6bca9@proxmox.com> (raw)
In-Reply-To: <20201214150453.28946-1-f.ebner@proxmox.com>
Forgot to mention that it's better viewed with --patience
Am 14.12.20 um 16:04 schrieb Fabian Ebner:
> This needs to happen in a separate loop, because some time intervals are not
> subsets of others, i.e. weeks and months. Previously, with a daily backup
> schedule, having:
> * a backup on Sun, 06 Dec 2020 kept by keep-daily
> * a backup on Sun, 29 Nov 2020 kept by keep-weekly
> would lead to the backup on Mon, 30 Nov 2020 to be selected for keep-monthly,
> because the iteration did not yet reach the backup on Sun, 29 Nov 2020 that
> would mark November as being covered.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> docs/prune-simulator/prune-simulator.js | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/docs/prune-simulator/prune-simulator.js b/docs/prune-simulator/prune-simulator.js
> index 5533c2d6..55cd548b 100644
> --- a/docs/prune-simulator/prune-simulator.js
> +++ b/docs/prune-simulator/prune-simulator.js
> @@ -485,16 +485,17 @@ Ext.onReady(function() {
>
> backups.forEach(function(backup) {
> let mark = backup.mark;
> - let id = idFunc(backup);
> -
> - if (finished || alreadyIncluded[id]) {
> - return;
> + if (mark && mark === 'keep') {
> + let id = idFunc(backup);
> + alreadyIncluded[id] = true;
> }
> + });
>
> - if (mark) {
> - if (mark === 'keep') {
> - alreadyIncluded[id] = true;
> - }
> + backups.forEach(function(backup) {
> + let mark = backup.mark;
> + let id = idFunc(backup);
> +
> + if (finished || alreadyIncluded[id] || mark) {
> return;
> }
>
>
next prev parent reply other threads:[~2020-12-14 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 15:04 Fabian Ebner
2020-12-14 15:08 ` Fabian Ebner [this message]
2020-12-15 13:04 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e333d53f-ea5a-5b22-b578-e5d556f6bca9@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox