From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH v2] proxmox-backup-proxy: stop accept() loop on daemon shutdown
Date: Mon, 2 May 2022 14:21:03 +0200 [thread overview]
Message-ID: <e2ebf435-5a44-78e8-4dc6-558520beae98@proxmox.com> (raw)
In-Reply-To: <20220429100452.968278-1-d.csapak@proxmox.com>
Am 4/29/22 um 12:04 schrieb Dominik Csapak:
> When a task was running during a reload, the old process would still
> accept connections, but drop them due to the closed receiving channel.
>
> This resulted in sporadic connection failures in such a scenario,
> depending on which process got the connection.
>
> To fix that poll the shutdown_future too during accept, and exit the
> loop then.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * only get the shutdown_future once and reuse it in the loop
> src/bin/proxmox-backup-proxy.rs | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
>
applied, thanks!
Added some more (root cause) info to the commit message and noted that
this alone doesn't explains the "why did it pop up *now*" question.
prev parent reply other threads:[~2022-05-02 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 10:04 [pbs-devel] " Dominik Csapak
2022-05-02 12:21 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2ebf435-5a44-78e8-4dc6-558520beae98@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox