[pbs-devel] [PATCH proxmox-backup] ui: only add delete parameter on token edit, not when creating tokens

[pbs-devel] [PATCH proxmox-backup] ui: only add delete parameter on token edit, not when creating tokens

[Shannon Sterz]

otherwise tokens without comments can no longer be created as the api
will reject the additional `delete` parameter. this bug was introduced
by commit:

3fdf876: api: token: make comment deletable
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/window/TokenEdit.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/window/TokenEdit.js b/www/window/TokenEdit.js
index d1c5555b..dfa58919 100644
--- a/www/window/TokenEdit.js
+++ b/www/window/TokenEdit.js
@@ -68,8 +68,10 @@ Ext.define('PBS.window.TokenEdit', {
 	    {
 		xtype: 'proxmoxtextfield',
 		name: 'comment',
-		deleteEmpty: true,
 		fieldLabel: gettext('Comment'),
+		cbind: {
+		    deleteEmpty: "{!isCreate}"
+		},
 	    },
 	],
     },
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup] ui: only add delete parameter on token edit, not when creating tokens

[Thomas Lamprecht]

Am 03.04.25 um 17:03 schrieb Shannon Sterz:
> otherwise tokens without comments can no longer be created as the api
> will reject the additional `delete` parameter. this bug was introduced
> by commit:
> 
> 3fdf876: api: token: make comment deletable
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  www/window/TokenEdit.js | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel