From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Nicolas Frey <n.frey@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox v3 2/3] pbs-api-types: jobs: add {read, verify}-threads to VerificationJobConfig
Date: Tue, 11 Nov 2025 11:22:05 +0100 [thread overview]
Message-ID: <e0edfd00-713b-42af-89e1-6da0e74f5db1@proxmox.com> (raw)
In-Reply-To: <20251110084417.173290-3-n.frey@proxmox.com>
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
On 11/10/25 9:44 AM, Nicolas Frey wrote:
> controls the number of parallel threads to read/verify chunks
> similarly to tape backup job `worker-threads`
>
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
> pbs-api-types/src/jobs.rs | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/pbs-api-types/src/jobs.rs b/pbs-api-types/src/jobs.rs
> index 4dbbef2b..2b9cef38 100644
> --- a/pbs-api-types/src/jobs.rs
> +++ b/pbs-api-types/src/jobs.rs
> @@ -203,6 +203,14 @@ pub const VERIFICATION_OUTDATED_AFTER_SCHEMA: Schema =
> optional: true,
> schema: crate::NS_MAX_DEPTH_SCHEMA,
> },
> + "read-threads": {
> + schema: crate::READ_THREADS_SCHEMA,
> + optional: true,
> + },
> + "verify-threads": {
> + schema: crate::VERIFY_THREADS_SCHEMA,
> + optional: true,
> + },
> }
> )]
> #[derive(Serialize, Deserialize, Updater, Clone, PartialEq)]
> @@ -233,6 +241,12 @@ pub struct VerificationJobConfig {
> /// how deep the verify should go from the `ns` level downwards. Passing 0 verifies only the
> /// snapshots on the same level as the passed `ns`, or the datastore root if none.
> pub max_depth: Option<usize>,
> + /// The number of read threads to use for the job.
> + #[serde(skip_serializing_if = "Option::is_none")]
> + pub read_threads: Option<usize>,
> + /// The number of verification threads to use for the job.
> + #[serde(skip_serializing_if = "Option::is_none")]
> + pub verify_threads: Option<usize>,
> }
>
> impl VerificationJobConfig {
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-11-11 10:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 8:44 [pbs-devel] [PATCH proxmox{, -backup} v3 0/9] parallelize chunk reads in verification Nicolas Frey
2025-11-10 8:44 ` [pbs-devel] [PATCH proxmox v3 1/3] pbs-api-types: add schema for {worker, read, verify}-threads Nicolas Frey
2025-11-11 10:22 ` Christian Ebner
2025-11-10 8:44 ` [pbs-devel] [PATCH proxmox v3 2/3] pbs-api-types: jobs: add {read, verify}-threads to VerificationJobConfig Nicolas Frey
2025-11-11 10:22 ` Christian Ebner [this message]
2025-11-10 8:44 ` [pbs-devel] [PATCH proxmox v3 3/3] pbs-api-types: use worker-threads schema for TapeBackupJobSetup Nicolas Frey
2025-11-11 10:22 ` Christian Ebner
2025-11-10 8:44 ` [pbs-devel] [PATCH proxmox-backup v3 1/6] api: verify: move chunk loading into parallel handler Nicolas Frey
2025-11-11 10:22 ` Christian Ebner
2025-11-10 8:44 ` [pbs-devel] [PATCH proxmox-backup v3 2/6] api: verify: bundle parameters into new struct Nicolas Frey
2025-11-11 10:22 ` Christian Ebner
2025-11-10 8:44 ` [pbs-devel] [PATCH proxmox-backup v3 3/6] api: verify: determine the number of threads to use with {read, verify}-threads Nicolas Frey
2025-11-11 10:22 ` Christian Ebner
2025-11-10 8:44 ` [pbs-devel] [PATCH proxmox-backup v3 4/6] api: verify: correct typo in comment Nicolas Frey
2025-11-11 10:22 ` Christian Ebner
2025-11-10 8:44 ` [pbs-devel] [PATCH proxmox-backup v3 5/6] api: verify: add {read, verify}-threads to update endpoint Nicolas Frey
2025-11-11 10:22 ` Christian Ebner
2025-11-10 8:44 ` [pbs-devel] [PATCH proxmox-backup v3 6/6] ui: verify: add option to set number of threads for job Nicolas Frey
2025-11-11 10:22 ` Christian Ebner
2025-11-11 10:21 ` [pbs-devel] [PATCH proxmox{, -backup} v3 0/9] parallelize chunk reads in verification Christian Ebner
2025-11-11 10:35 ` Nicolas Frey
2025-11-13 9:33 ` [pbs-devel] superseded: " Nicolas Frey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0edfd00-713b-42af-89e1-6da0e74f5db1@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=n.frey@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox