From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox] s3-client: properly uri encode request query parameters
Date: Mon, 25 Aug 2025 11:35:44 +0200 [thread overview]
Message-ID: <dkobtcxewvrowpase3koerqpj3462vbzppntdjy5ukah6ukll2@r2ndbop3k6am> (raw)
In-Reply-To: <20250821120435.334573-1-c.ebner@proxmox.com>
applied, thanks
On Thu, Aug 21, 2025 at 02:04:35PM +0200, Christian Ebner wrote:
> Slashes in object keys as part of the url must not be uri encoded.
> They should however be for the query parameters.
>
> Fix this by correctly setting the flag signaling the
> aws_sign_v4_uri_encode helper that this is not to be encoded as
> object key.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Noticed in the ceph RGW debug log output while checking an unrelated
> issue.
>
> proxmox-s3-client/src/client.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs
> index 3bc2a672..7a3fb89a 100644
> --- a/proxmox-s3-client/src/client.rs
> +++ b/proxmox-s3-client/src/client.rs
> @@ -698,10 +698,10 @@ impl S3Client {
> // No further input validation as http::uri::Builder will check path and query
> let mut query_iter = query.iter().peekable();
> while let Some((key, value)) = query_iter.next() {
> - let key = aws_sign_v4_uri_encode(key, true);
> + let key = aws_sign_v4_uri_encode(key, false);
> path_and_query.push_str(&key);
> if !value.is_empty() {
> - let value = aws_sign_v4_uri_encode(value, true);
> + let value = aws_sign_v4_uri_encode(value, false);
> path_and_query.push('=');
> path_and_query.push_str(&value);
> }
> --
> 2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-08-25 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 12:04 [pbs-devel] " Christian Ebner
2025-08-25 9:35 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dkobtcxewvrowpase3koerqpj3462vbzppntdjy5ukah6ukll2@r2ndbop3k6am \
--to=w.bumiller@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox