Re: [pbs-devel] [PATCH proxmox-backup v3] restrict consent-banner text length

From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] restrict consent-banner text length
Date: Tue, 8 Apr 2025 14:58:43 +0200	[thread overview]
Message-ID: <dhuywqe42lqae2twugmnzabtxokladjwjn2hqummlw5vdd5nxx@imeit6ai7msu> (raw)
In-Reply-To: <e0cfec76-5149-4d3d-80be-b96ae633e1ee@proxmox.com>

On 08.04.2025 13:08, Thomas Lamprecht wrote:
>Am 10.12.24 um 16:53 schrieb Gabriel Goller:
>> Add a maxLength in of 63*1024 in the frontend. We allow a max body
>> size of 64*1204 in the api and to allow some other properties to
>> coexist, reserve 1024 characters. In the backend we set the limit to
>> 128000 (128kB), which is the same as in pve.
>
>I reduced it in PVE a bit again; might also make sense to increase the
>max POST size to 512 KiB just like in PVE, the rust based HTTP server
>should handle these sizes without a sweat if the perl one can do that.

I'll send a patch soon with a limit of 64kB on both frontend and api.
The increasing of the max body size is IMO better in a future patch as
that will need some testing.

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel