From: Dietmar Maurer <dietmar@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] client/pull: log snapshots that are skipped because of time
Date: Fri, 4 Jun 2021 11:03:24 +0200 [thread overview]
Message-ID: <debe42a1-a782-5ad3-5948-af1d8b482475@proxmox.com> (raw)
In-Reply-To: <1622794517.ypqwqri9n2.astroid@nora.none>
On 6/4/21 10:21 AM, Fabian Grünbichler wrote:
>
>> @@ -495,6 +496,11 @@ pub async fn pull_group(
>>
>> if let Some(last_sync_time) = last_sync {
>> if last_sync_time > backup_time {
>> + task_log!(
>> + worker,
>> + "skipping snapshot {} - older than last sync",
>> + snapshot
>> + );
> adding this would mean that sync logs would grow and grow and grow over
> time..
>
> maybe a single:
>
> skipped 32 remote snapshots (2021-MM-DDTHH:MM::SSZ..2021-MM-DDTHH:MM::SSZ) older than newest local snapshot.
>
> it would mean only adding a single line to the output, but contains
> almost all the information?
>
I would also prefer a single log line.
next prev parent reply other threads:[~2021-06-04 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 7:16 Dominik Csapak
2021-06-04 8:21 ` Fabian Grünbichler
2021-06-04 9:03 ` Dietmar Maurer [this message]
2021-06-04 9:04 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=debe42a1-a782-5ad3-5948-af1d8b482475@proxmox.com \
--to=dietmar@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox