From: Stefan Sterz <s.sterz@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH qemu-server] cdrom handling: default to "none" if no physical drive is available
Date: Fri, 16 Dec 2022 16:08:03 +0100 [thread overview]
Message-ID: <dd524cad-d76a-a2f4-f1c1-7472233d917c@proxmox.com> (raw)
In-Reply-To: <20221216150711.1677615-1-s.sterz@proxmox.com>
On 12/16/22 16:07, Stefan Sterz wrote:
> when a vm is configured to use the physical cd rom drive but there is
> no such drive a cryptic "uninitialized value" error is thrown. this
> is due to the `$path` not being defined in `sub
> print_drive_commandline_full` in this case. warn that no cd rom drive
> is available and default back to using "none" as media instead.
>
> note that the error was basically cosmetic as the vm would start just
> fine.
>
> forum thread: https://forum.proxmox.com/threads/use-of-uninitialized-value-path-in-pattern-match-m-at-usr-share-perl5-pve-qemuserver-pm-line-1622.119592/
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> PVE/QemuServer.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index dd6ea3e..bc935df 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -1292,6 +1292,9 @@ sub get_cdrom_path {
> return $cdrom_path = "/dev/cdrom" if -l "/dev/cdrom";
> return $cdrom_path = "/dev/cdrom1" if -l "/dev/cdrom1";
> return $cdrom_path = "/dev/cdrom2" if -l "/dev/cdrom2";
> +
> + warn "there is no physical cdrom drive that can be used. defaulting back to 'none'.";
> + return '';
> }
>
> sub get_iso_path {
ah sorry wrong list :(
prev parent reply other threads:[~2022-12-16 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 15:07 Stefan Sterz
2022-12-16 15:08 ` Stefan Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd524cad-d76a-a2f4-f1c1-7472233d917c@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox