Re: [PATCH widget-toolkit v2] fix #7721: fix zoom interaction on charts with no initial store

[Christian Ebner <c.ebner@proxmox.com>]

On 8/11/26 10:57 AM, Dominik Csapak wrote:
> In our current ExtJs version (7.0), having animations disabled on charts
> breaks the zoom interaction. One can zoom in and out once, but never
> again.
> 
> We generally keep animations enabled on our proxmoxRRDChart, but only
> after the store's first load, to avoid animating from the empty store to
> the initial data. This happens in initComponent on the store that was
> given during instantiation.
> 
> In some cases, however (e.g. the PBS datastore summary panel), the chart
> has no initial store and instead gets one via 'setStore'. Here, the
> event of the old (non-existent) store was never fired, so animations
> were never activated and the zoom interaction was buggy.
> 
> Fix this by overriding `setStore` to install an event handler for the
> new store that enables the animations. If this runs more than once, it
> would just set the animation value to the same again, which is fine.
> 
> Also guard the delay method against calls from `setStore(null)` which
> can happen when a component is being destroyed.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---

Double checked the animations already fixed in v1 for PBS, that the 
issue when switching between datastores is no longer present in v2 and 
that there are no regressions for PVE.

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>