Re: [pbs-devel] [PATCH proxmox-backup 5/5] fix #3887: ui: add regenerate token button

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 20/12/2022 15:57, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  www/config/TokenView.js | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/www/config/TokenView.js b/www/config/TokenView.js
> index 6282a4d4..745f1378 100644
> --- a/www/config/TokenView.js
> +++ b/www/config/TokenView.js
> @@ -100,6 +100,30 @@ Ext.define('PBS.config.TokenView', {
>  	    }).show();
>  	},
>  
> +	regenerateToken: function() {

note that with using a proxmoxButton this has the signature of

(button, event, rec)

where the record probably should be enough to avoid pulling out the selection manually.

> +            let me = this;
> +            let view = me.getView();
> +            let selection = view.getSelection();
> +            if (selection.length < 1) return;
> +            let tokenid = selection[0].data.tokenid;
> +            let user = PBS.Utils.extractTokenUser(tokenid);
> +            let tokenname = PBS.Utils.extractTokenName(tokenid);
> +            Proxmox.Utils.API2Request({
> +                method: "POST",
> +                url: `/access/users/${user}/token/${tokenname}/regenerate`,
> +                success: function(res, opt) {
> +                    Ext.create("PBS.window.TokenShow", {
> +                        autoShow: true,
> +                        tokenid: res.result.data.tokenid,
> +                        secret: res.result.data.value,
> +                    });
> +                },
> +                failure: function(response, opt) {
> +                    Ext.Msg.alert(gettext("Error"), response.htmlStatus);
> +                },

would prefer a arrow fn here:

failure: res => Ext.Msg.alert(gettext("Error"), res.htmlStatus),

> +            });
> +        },
> +
>  	showPermissions: function() {
>  	    let me = this;
>  	    let view = me.getView();
> @@ -174,6 +198,12 @@ Ext.define('PBS.config.TokenView', {
>  	    handler: 'showPermissions',
>  	    disabled: true,
>  	},
> +	{
> +	    xtype: 'proxmoxButton',
> +	    text: gettext('Regenerate'),
> +	    handler: 'regenerateToken',

I'd really set the proxmoxButton's config for confirming and auto-selecting
the no choice by default to avoid that an "sneeze-and-click" accident revokes
access of an in-use token without any confirmation prompt at all.

E.g., add something like:

    dangerous: true,
    confirmMsg: rec => Ext.String.format(
        gettext("Regenerate the secret of the API token '{0}'? All current use-sites will loose access!"),
        rec.data.tokenid, // <- just a guesstimate, didn't actually test this
    ),

The function could also just be a plain text without referencing the token ID,
but IMO it has some non-negligible value to show such things in confirmations.

> +	    disabled: true,
> +	},
>      ],
>  
>      viewConfig: {
))))