Re: [pbs-devel] [PATCH proxmox-backup v2 1/3] api: taffic-control: update/delete users on rule correctly

From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 1/3] api: taffic-control: update/delete users on rule correctly
Date: Mon, 10 Nov 2025 09:56:05 +0100	[thread overview]
Message-ID: <d982d258-1aea-48ea-92ea-4e83274b3a85@proxmox.com> (raw)
In-Reply-To: <20251107132329.42965-5-h.laimer@proxmox.com>


Reviewed-by: Christian Ebner <c.ebner@proxmox.com>

On 11/7/25 2:23 PM, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>   src/api2/config/traffic_control.rs | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/src/api2/config/traffic_control.rs b/src/api2/config/traffic_control.rs
> index e02aa20a..49b1267e 100644
> --- a/src/api2/config/traffic_control.rs
> +++ b/src/api2/config/traffic_control.rs
> @@ -116,6 +116,8 @@ pub enum DeletableProperty {
>       Comment,
>       /// Delete the timeframe property
>       Timeframe,
> +    /// Delete the users property
> +    Users,
>   }
>   
>   // fixme: use  TrafficControlUpdater
> @@ -187,6 +189,9 @@ pub fn update_traffic_control(
>                   DeletableProperty::Timeframe => {
>                       data.timeframe = None;
>                   }
> +                DeletableProperty::Users => {
> +                    data.users = None;
> +                }
>               }
>           }
>       }
> @@ -222,6 +227,9 @@ pub fn update_traffic_control(
>       if update.timeframe.is_some() {
>           data.timeframe = update.timeframe;
>       }
> +    if update.users.is_some() {
> +        data.users = update.users;
> +    }
>   
>       config.set_data(&name, "rule", &data)?;
>   


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel