From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [RFC PATCH proxmox-backup 1/3] api-types: make UploadStatistic an api type
Date: Mon, 27 Nov 2023 11:12:46 +0100 [thread overview]
Message-ID: <d8f7bdf9-6a63-4e06-aaea-3ae1bca95caa@proxmox.com> (raw)
In-Reply-To: <43fbabe3-1c51-4d6b-ba92-6e570b985d62@proxmox.com>
On 27.11.23 11:01, Dominik Csapak wrote:
> On 11/27/23 10:52, Thomas Lamprecht wrote:
>> On 01.08.23 11:29, Dominik Csapak wrote:
>>> +#[api()]
>>> +#[derive(Copy, Clone, Serialize, Deserialize)]
>>
>> misses:
>>
>> #[serde(rename_all = "kebab-case")]
>>
>> or does that break manifest?
>
> it shouldn't since we only save it in the 'unprotected' field that is a 'Value'
> but i'll check
I did not mean breakage as in "might break signatures", but as in
backward/forward compat to any of our code/tools using that field
already (tbh. not sure from top of my head if serde json magically
falls back to field casing variants, e.g., check if foo-bar is there
if not take foo_bar, I think not, so that's why I asked - should have
said so in my first response).
next prev parent reply other threads:[~2023-11-27 10:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 9:29 [pbs-devel] [RFC PATCH proxmox-backup 0/3] show upload statistics in gui Dominik Csapak
2023-08-01 9:29 ` [pbs-devel] [RFC PATCH proxmox-backup 1/3] api-types: make UploadStatistic an api type Dominik Csapak
2023-11-27 9:52 ` Thomas Lamprecht
2023-11-27 10:01 ` Dominik Csapak
2023-11-27 10:12 ` Thomas Lamprecht [this message]
2023-11-27 10:17 ` Dominik Csapak
2023-11-27 12:44 ` Wolfgang Bumiller
2023-11-27 14:57 ` Dominik Csapak
2023-08-01 9:29 ` [pbs-devel] [RFC PATCH proxmox-backup 2/3] api: datastore: add upload_statistic to snapshot listing Dominik Csapak
2023-11-27 9:08 ` Wolfgang Bumiller
2023-08-01 9:29 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: datastore content: add action to show upload statistics Dominik Csapak
2023-11-27 9:28 ` Thomas Lamprecht
2023-11-27 10:04 ` Dominik Csapak
2023-11-27 10:27 ` Thomas Lamprecht
2023-11-27 10:33 ` Dominik Csapak
2023-11-27 12:02 ` Thomas Lamprecht
2023-11-27 12:08 ` Dominik Csapak
2023-11-27 10:07 ` Thomas Lamprecht
2023-11-27 10:15 ` Dominik Csapak
2023-11-27 12:06 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8f7bdf9-6a63-4e06-aaea-3ae1bca95caa@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox