From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] jobstate: fix wrong error message
Date: Tue, 7 Mar 2023 19:36:57 +0100 [thread overview]
Message-ID: <d8f1755d-f350-ab4d-570b-84834ffa1084@proxmox.com> (raw)
In-Reply-To: <20230307141057.822269-1-d.csapak@proxmox.com>
Am 07/03/2023 um 15:10 schrieb Dominik Csapak:
> we try to create the job stat dir, not the rrdb one
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/server/jobstate.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/server/jobstate.rs b/src/server/jobstate.rs
> index 4f347ad1..74af992f 100644
> --- a/src/server/jobstate.rs
> +++ b/src/server/jobstate.rs
> @@ -88,7 +88,7 @@ pub fn create_jobstate_dir() -> Result<(), Error> {
> .group(backup_user.gid);
>
> create_path(JOB_STATE_BASEDIR, Some(opts.clone()), Some(opts))
> - .map_err(|err: Error| format_err!("unable to create rrdb stat dir - {}", err))?;
> + .map_err(|err: Error| format_err!("unable to create job stat dir - {}", err))?;
no biggie, but in general feel free (or even encouraged) to inline format string
variables when touching lines anyway, like {err} here.
>
> Ok(())
> }
prev parent reply other threads:[~2023-03-07 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 14:10 Dominik Csapak
2023-03-07 14:50 ` [pbs-devel] applied: " Wolfgang Bumiller
2023-03-07 18:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8f1755d-f350-ab4d-570b-84834ffa1084@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox