Re: [PATCH proxmox-backup v2] datastore: don't skip empty namespaces on s3 refresh

[Hannes Laimer <h.laimer@proxmox.com>]

On 2026-03-05 10:20, Hannes Laimer wrote:
> Without this empty namespaces present on s3 won't be visible locally.
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> v2, thanks @Fabian:
>  - don't duplicate dir creation, just move ns check to after dir
>    creation since it is identicaly for namespaces and other things
> 
>  pbs-datastore/src/datastore.rs | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
> index 7ad3d917..76b66f7d 100644
> --- a/pbs-datastore/src/datastore.rs
> +++ b/pbs-datastore/src/datastore.rs
> @@ -2534,11 +2534,6 @@ impl DataStore {
>                  let object_path = object_path.strip_prefix(&store_prefix).with_context(|| {
>                      format!("failed to strip store context prefix {store_prefix} for {object_key}")
>                  })?;
> -                if object_path.ends_with(NAMESPACE_MARKER_FILENAME) {
> -                    continue;
> -                }
> -
> -                info!("Fetching object {object_path}");
>  
>                  let file_path = tmp_base.join(object_path);
>                  if let Some(parent) = file_path.parent() {
> @@ -2549,6 +2544,13 @@ impl DataStore {
>                      )?;
>                  }
>  
> +                if object_path.ends_with(NAMESPACE_MARKER_FILENAME) {
> +                    info!("Created namespace {object_path}");
> +                    continue;
> +                } else {
                     ^^
not wrong technically, but doesn't make much sense... :P
sorry for the noise

> +                    info!("Fetching object {object_path}");
> +                }
> +
>                  let mut target_file = tokio::fs::OpenOptions::new()
>                      .write(true)
>                      .create(true)