public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 0/5] improve duplicate label-text handling
Date: Fri, 12 Jan 2024 10:27:48 +0100	[thread overview]
Message-ID: <d7d65dc3-9e79-4227-a6ee-f5a00e15506e@proxmox.com> (raw)
In-Reply-To: <20240111104036.3341854-1-d.csapak@proxmox.com>

applied

On 1/11/24 11:40, Dominik Csapak wrote:
> while most of the code assumes each label is unique in the inventory,
> there is actually no safeguard against doing that.
>
> this can lead to confusion about which tape is
> inserted/online/destroyed/vaulted/etc.
>
> so this series tries to improve the handling a bit by logging a warning
> when encountering this, and also preventing new tapes being labeled with
> an existing label
>
> also add the 'destroy' media function to the ui, so that users
> can get more easily out of this situation
>
> Dominik Csapak (5):
>    tape: handle duplicate label-texts in inventory
>    api: tape: optinally accept uuid for destroy/move media
>    api: tape: don't allow duplicate media label-texts
>    ui: tape inventory: use uuid as id
>    ui: tape: add remove media button
>
>   src/api2/tape/drive.rs                | 79 +++++++++++++++++--------
>   src/api2/tape/media.rs                | 84 ++++++++++++++++++++++-----
>   src/tape/changer/online_status_map.rs | 26 +++++----
>   src/tape/inventory.rs                 | 26 ++++++---
>   www/Makefile                          |  1 +
>   www/tape/TapeInventory.js             | 35 ++++++++++-
>   www/tape/window/MediaRemoveWindow.js  | 66 +++++++++++++++++++++
>   7 files changed, 257 insertions(+), 60 deletions(-)
>   create mode 100644 www/tape/window/MediaRemoveWindow.js
>




      parent reply	other threads:[~2024-01-12  9:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 10:40 [pbs-devel] " Dominik Csapak
2024-01-11 10:40 ` [pbs-devel] [PATCH proxmox-backup 1/5] tape: handle duplicate label-texts in inventory Dominik Csapak
2024-01-12  7:29   ` Dietmar Maurer
2024-01-12  7:35     ` Dominik Csapak
2024-01-12  8:01       ` Dietmar Maurer
2024-01-12  8:09         ` Dominik Csapak
2024-01-11 10:40 ` [pbs-devel] [PATCH proxmox-backup 2/5] api: tape: optinally accept uuid for destroy/move media Dominik Csapak
2024-01-11 10:40 ` [pbs-devel] [PATCH proxmox-backup 3/5] api: tape: don't allow duplicate media label-texts Dominik Csapak
2024-01-11 10:40 ` [pbs-devel] [PATCH proxmox-backup 4/5] ui: tape inventory: use uuid as id Dominik Csapak
2024-01-11 10:40 ` [pbs-devel] [PATCH proxmox-backup 5/5] ui: tape: add remove media button Dominik Csapak
2024-01-11 10:43 ` [pbs-devel] [PATCH proxmox-backup 0/5] improve duplicate label-text handling Dominik Csapak
2024-01-12  9:27 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7d65dc3-9e79-4227-a6ee-f5a00e15506e@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal