[pbs-devel] [PATCH proxmox-backup v2] report: better hardware and system utilization overview.

[pbs-devel] [PATCH proxmox-backup v2] report: better hardware and system utilization overview.

[Hannes Duerr]

instead of `ls -l /dev/disk/by-id /dev/disk/by-path` the command
`bash -c ls -l /dev/disk/by-*` is beeing used which displays the discs not only
by-id and by-path, but also by-diskseq, by-label, by-uuid, and
by-partuuid, which can be very helpful when assigning iSCSI and
multipath devices.
The execution in bash allows the use of asterisks.

`dmidecode -t bios` outputs the current BIOS version and which allows to
determine whether certain fixes have already been implemented in the
version or not.

`lscpu` provides a good overview of the CPU being used, its flags, and
existing/non-existing mitigations.

`lspci -nnk` displays all PCI devices and the drivers used, which is often
helpful when troubleshooting.

`ip -details -statistics a` provides a detailed overview of the
available interfaces and statistics since the last boot. This
information is often helpful in addressing performance issues and
assessments.

Suggested-by: Sviatoslav Brylenko <s.brylenko@proxmox.com>
Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
---

Notes:
    changes since V1:
    * add bash -c to enable the usage of the asterics

 src/server/report.rs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/server/report.rs b/src/server/report.rs
index ca5f04fc..546555fb 100644
--- a/src/server/report.rs
+++ b/src/server/report.rs
@@ -82,10 +82,14 @@ fn commands() -> Vec<(&'static str, Vec<&'static str>)> {
                 "+HOTPLUG,ROTA,PHY-SEC,FSTYPE,MODEL,TRAN",
             ],
         ),
-        ("ls", vec!["-l", "/dev/disk/by-id", "/dev/disk/by-path"]),
+        ("bash", vec!["-c", "ls -l /dev/disk/by-*/"]),
         ("zpool", vec!["status"]),
         ("zfs", vec!["list"]),
         ("arcstat", vec![]),
+        ("dmidecode", vec!["-t", "bios"]),
+        ("lscpu", vec![]),
+        ("lspci", vec!["-nnk"]),
+        ("ip", vec!["-details", "-statistics", "a"]),
     ]
 }
 
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup v2] report: better hardware and system utilization overview.

[Christian Ebner]

On 10/24/25 2:19 PM, Hannes Duerr wrote:
> instead of `ls -l /dev/disk/by-id /dev/disk/by-path` the command
> `bash -c ls -l /dev/disk/by-*` is beeing used which displays the discs not only
> by-id and by-path, but also by-diskseq, by-label, by-uuid, and
> by-partuuid, which can be very helpful when assigning iSCSI and
> multipath devices.
> The execution in bash allows the use of asterisks.
> 
> `dmidecode -t bios` outputs the current BIOS version and which allows to
> determine whether certain fixes have already been implemented in the
> version or not.
> 
> `lscpu` provides a good overview of the CPU being used, its flags, and
> existing/non-existing mitigations.
> 
> `lspci -nnk` displays all PCI devices and the drivers used, which is often
> helpful when troubleshooting.
> 
> `ip -details -statistics a` provides a detailed overview of the
> available interfaces and statistics since the last boot. This
> information is often helpful in addressing performance issues and
> assessments.
> 
> Suggested-by: Sviatoslav Brylenko <s.brylenko@proxmox.com>
> Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
> ---

Patch looks good to me, although we probably should explicitly depend on
`util-linux`, `dmidecode` and `pciutils` packages for 
`proxmox-backup-sever` in debian/control then to assure the expected 
binaries are installed.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup v2] report: better hardware and system utilization overview.

[Thomas Lamprecht]

Am 29.10.25 um 09:30 schrieb Christian Ebner:
> On 10/24/25 2:19 PM, Hannes Duerr wrote:
>> instead of `ls -l /dev/disk/by-id /dev/disk/by-path` the command
>> `bash -c ls -l /dev/disk/by-*` is beeing used which displays the discs not only
>> by-id and by-path, but also by-diskseq, by-label, by-uuid, and
>> by-partuuid, which can be very helpful when assigning iSCSI and
>> multipath devices.
>> The execution in bash allows the use of asterisks.
>>
>> `dmidecode -t bios` outputs the current BIOS version and which allows to
>> determine whether certain fixes have already been implemented in the
>> version or not.
>>
>> `lscpu` provides a good overview of the CPU being used, its flags, and
>> existing/non-existing mitigations.
>>
>> `lspci -nnk` displays all PCI devices and the drivers used, which is often
>> helpful when troubleshooting.
>>
>> `ip -details -statistics a` provides a detailed overview of the
>> available interfaces and statistics since the last boot. This
>> information is often helpful in addressing performance issues and
>> assessments.
>>
>> Suggested-by: Sviatoslav Brylenko <s.brylenko@proxmox.com>
>> Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
>> ---
> 
> Patch looks good to me, although we probably should explicitly depend on
> `util-linux`, `dmidecode` and `pciutils` packages for `proxmox-backup-sever` in debian/control then to assure the expected binaries are installed.
> 

Yes, that's especially important for those installing on top of Debian,
e.g. for inside a container or some other more minimal set up environment.

And the standard set that we add in the installer might also change.
And while a bit unlikely, it's not a given that these tools will always
be available after installing through our official ISO.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup v2] report: better hardware and system utilization overview.

[Hannes Duerr]

ping.
Would be nice if this gets included in the upcoming release.

On 10/24/25 2:19 PM, Hannes Duerr wrote:
> instead of `ls -l /dev/disk/by-id /dev/disk/by-path` the command
> `bash -c ls -l /dev/disk/by-*` is beeing used which displays the discs not only
> by-id and by-path, but also by-diskseq, by-label, by-uuid, and
> by-partuuid, which can be very helpful when assigning iSCSI and
> multipath devices.
> The execution in bash allows the use of asterisks.
>
> `dmidecode -t bios` outputs the current BIOS version and which allows to
> determine whether certain fixes have already been implemented in the
> version or not.
>
> `lscpu` provides a good overview of the CPU being used, its flags, and
> existing/non-existing mitigations.
>
> `lspci -nnk` displays all PCI devices and the drivers used, which is often
> helpful when troubleshooting.
>
> `ip -details -statistics a` provides a detailed overview of the
> available interfaces and statistics since the last boot. This
> information is often helpful in addressing performance issues and
> assessments.
>
> Suggested-by: Sviatoslav Brylenko <s.brylenko@proxmox.com>
> Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
> ---
>
> Notes:
>      changes since V1:
>      * add bash -c to enable the usage of the asterics
>
>   src/server/report.rs | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/server/report.rs b/src/server/report.rs
> index ca5f04fc..546555fb 100644
> --- a/src/server/report.rs
> +++ b/src/server/report.rs
> @@ -82,10 +82,14 @@ fn commands() -> Vec<(&'static str, Vec<&'static str>)> {
>                   "+HOTPLUG,ROTA,PHY-SEC,FSTYPE,MODEL,TRAN",
>               ],
>           ),
> -        ("ls", vec!["-l", "/dev/disk/by-id", "/dev/disk/by-path"]),
> +        ("bash", vec!["-c", "ls -l /dev/disk/by-*/"]),
>           ("zpool", vec!["status"]),
>           ("zfs", vec!["list"]),
>           ("arcstat", vec![]),
> +        ("dmidecode", vec!["-t", "bios"]),
> +        ("lscpu", vec![]),
> +        ("lspci", vec!["-nnk"]),
> +        ("ip", vec!["-details", "-statistics", "a"]),
>       ]
>   }
>   


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup v2] report: better hardware and system utilization overview.

[Christian Ebner]

On 11/11/25 5:09 PM, Hannes Duerr wrote:
> ping.
> Would be nice if this gets included in the upcoming release.

Hi, most definitely!

Could you however resend a new version of the patch to also include the 
suggested debian/control dependencies?

Thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [FOLLOW-UP proxmox-backup] d/control: add dependencies for binaries used in system report

[Christian Ebner]

Obtained via dpkg -S $(which <binary-name>), in particular:
- dmidecode for dmidecode
- iproute2 for ip
- pciutils for lspci
- util-linux for lscpu

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
This is a followup for:
https://lore.proxmox.com/pbs-devel/20251024121830.172352-1-h.duerr@proxmox.com/

  debian/control | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 48b732eb9..08ec49515 100644
--- a/debian/control
+++ b/debian/control
@@ -189,8 +189,10 @@ Rules-Requires-Root: binary-targets

  Package: proxmox-backup-server
  Architecture: any
-Depends: fonts-font-awesome,
+Depends: dmidecode,
+         fonts-font-awesome,
           gdisk,
+         iproute2,
           libjs-extjs (>= 7~),
           libjs-qrcodejs (>= 1.20201119),
           libproxmox-acme-plugins,
@@ -198,6 +200,7 @@ Depends: fonts-font-awesome,
           libzstd1 (>= 1.3.8),
           lvm2,
           openssh-server,
+         pciutils,
           pbs-i18n,
           postfix | mail-transport-agent,
           proxmox-backup-docs,
@@ -207,6 +210,7 @@ Depends: fonts-font-awesome,
           pve-xtermjs (>= 4.7.0-1),
           sg3-utils,
           smartmontools,
+         util-linux,
           ${misc:Depends},
           ${shlibs:Depends},
  Recommends: ifupdown2,
--
2.47.3


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [FOLLOW-UP proxmox-backup] d/control: add dependencies for binaries used in system report

[Christian Ebner]

On 11/20/25 3:57 PM, Christian Ebner wrote:
> Obtained via dpkg -S $(which <binary-name>), in particular:
> - dmidecode for dmidecode
> - iproute2 for ip
> - pciutils for lspci
> - util-linux for lscpu
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> This is a followup for:
> https://lore.proxmox.com/pbs-devel/20251024121830.172352-1- 
> h.duerr@proxmox.com/
> 
>   debian/control | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/debian/control b/debian/control
> index 48b732eb9..08ec49515 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -189,8 +189,10 @@ Rules-Requires-Root: binary-targets
> 
>   Package: proxmox-backup-server
>   Architecture: any
> -Depends: fonts-font-awesome,
> +Depends: dmidecode,
> +         fonts-font-awesome,
>            gdisk,
> +         iproute2,
>            libjs-extjs (>= 7~),
>            libjs-qrcodejs (>= 1.20201119),
>            libproxmox-acme-plugins,
> @@ -198,6 +200,7 @@ Depends: fonts-font-awesome,
>            libzstd1 (>= 1.3.8),
>            lvm2,
>            openssh-server,
> +         pciutils,
>            pbs-i18n,
>            postfix | mail-transport-agent,
>            proxmox-backup-docs,
> @@ -207,6 +210,7 @@ Depends: fonts-font-awesome,
>            pve-xtermjs (>= 4.7.0-1),
>            sg3-utils,
>            smartmontools,
> +         util-linux,

only realized now that this requires and explicit version and should be

util-linux (>= 2.41-5),

Please let me know if I should resend this or if this can be folded in 
when applied.

>            ${misc:Depends},
>            ${shlibs:Depends},
>   Recommends: ifupdown2,
> -- 
> 2.47.3
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel