From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox v3] fix #3302: allow for more characters for email
Date: Wed, 12 May 2021 21:20:04 +0200 [thread overview]
Message-ID: <d70a05ef-9a7e-11d3-51ca-f68b42c946f3@proxmox.com> (raw)
In-Reply-To: <20210512142016.3476-1-d.csapak@proxmox.com>
On 12.05.21 16:20, Dominik Csapak wrote:
> by removing the regex check here, that is responsibility of the caller
>
> this is ok since we pass the args directly and not via shell, so
> command injection should not be possible
yeah, if nothing is there to interpret injected commands then it really isn't
possible, besides naturally some security issue in sendmail command parser or
the like, but there's no future proofing against that.. ;-)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> tested command injection with emails like '--help' but this got sent
> to '--help@myhostname' which got sent to 'root@myhostname'
>
> proxmox/src/tools/email.rs | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-05-12 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 14:20 [pbs-devel] " Dominik Csapak
2021-05-12 19:20 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d70a05ef-9a7e-11d3-51ca-f68b42c946f3@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox