From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] ui: fix deleting datastore without 'keep-job-configs'
Date: Thu, 30 Nov 2023 10:18:56 +0100 [thread overview]
Message-ID: <d6c59746-8278-4d82-aa22-c8fbffc21902@proxmox.com> (raw)
In-Reply-To: <20231130084903.1189798-1-d.csapak@proxmox.com>
Am 30/11/2023 um 09:49 schrieb Dominik Csapak:
> without any default value in the viewModel, the resulting url would be:
>
> `<id>?destroy-data=<value>&keep-job-configs=`
>
> which is missing the actual value, so add the default
>
> Fixes: e9979a1a ("ui: add 'keep configs' checkbox to datastore removal window")
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/datastore/OptionView.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, with Fiona's T-b, thanks!
prev parent reply other threads:[~2023-11-30 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 8:49 [pbs-devel] " Dominik Csapak
2023-11-30 9:05 ` Fiona Ebner
2023-11-30 9:18 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6c59746-8278-4d82-aa22-c8fbffc21902@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox