From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v3 0/7] add compression to api/static files and zip
Date: Wed, 7 Apr 2021 18:00:22 +0200 [thread overview]
Message-ID: <d47fef39-b4b2-ab4a-b9a5-197689f86547@proxmox.com> (raw)
In-Reply-To: <20210406090347.27579-1-d.csapak@proxmox.com>
On 06.04.21 11:03, Dominik Csapak wrote:
> this series combines my two series about adding compression to
> api calls/static as well as the zip deflate series
>
> changes from v2:
> compression:
> * comment out non 'Deflate' CompressionMethods to have better match arms
> * use constants for 'magic' values
> * (partially) parse accept-encoding qualifiers
> zip:
> * use DeflateEncoder instead of flate2 manually
> * reorder patches so that the rustfmt patch comes first
>
> Dominik Csapak (7):
> tools: add compression module
> tools/compression: add DeflateEncoder and helpers
> server/rest: add helper to extract compression headers
> server/rest: compress api calls
> server/rest: compress static files
> tools/zip: run rustfmt
> tools/zip: compress zips with deflate
>
> Cargo.toml | 1 +
> src/server/rest.rs | 121 ++++++++++++++++----
> src/tools.rs | 1 +
> src/tools/compression.rs | 232 +++++++++++++++++++++++++++++++++++++++
> src/tools/zip.rs | 133 +++++++++++++++-------
> 5 files changed, 425 insertions(+), 63 deletions(-)
> create mode 100644 src/tools/compression.rs
>
applied series, much thanks!
As talked off-list I switched to Level::Default, while slightly slower on a
"no network bottle neck" benchmark its actually smaller and faster in total on
a real world benchmark with a throttled and latency spiked connection.
(See followup commit message for detail and benchmark results)
prev parent reply other threads:[~2021-04-07 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 9:03 [pbs-devel] " Dominik Csapak
2021-04-06 9:03 ` [pbs-devel] [PATCH proxmox-backup v3 1/7] tools: add compression module Dominik Csapak
2021-04-06 9:03 ` [pbs-devel] [PATCH proxmox-backup v3 2/7] tools/compression: add DeflateEncoder and helpers Dominik Csapak
2021-04-06 9:03 ` [pbs-devel] [PATCH proxmox-backup v3 3/7] server/rest: add helper to extract compression headers Dominik Csapak
2021-04-06 9:03 ` [pbs-devel] [PATCH proxmox-backup v3 4/7] server/rest: compress api calls Dominik Csapak
2021-04-06 9:03 ` [pbs-devel] [PATCH proxmox-backup v3 5/7] server/rest: compress static files Dominik Csapak
2021-04-06 9:03 ` [pbs-devel] [PATCH proxmox-backup v3 6/7] tools/zip: run rustfmt Dominik Csapak
2021-04-06 9:03 ` [pbs-devel] [PATCH proxmox-backup v3 7/7] tools/zip: compress zips with deflate Dominik Csapak
2021-04-07 16:00 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d47fef39-b4b2-ab4a-b9a5-197689f86547@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox