From: Lukas Wagner <l.wagner@proxmox.com>
To: Markus Frank <m.frank@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: add Remove button for DirectoryList
Date: Tue, 10 Oct 2023 11:13:06 +0200 [thread overview]
Message-ID: <d477856a-e63c-4c05-9c34-ec9ec5c4cc99@proxmox.com> (raw)
In-Reply-To: <7efa009d-a474-41db-b4bd-6e6cf78606c2@proxmox.com>
On 10/10/23 11:05, Markus Frank wrote:
>>> store: {
>>> fields: ['path', 'device', 'filesystem', 'options', 'unitfile'],
>>> proxy: {
>>
>> A high-level comment about the UI changes:
>> In most places in our UI, we have a dedicated 'Remove' button right next
>> to the 'Add/Create' and 'Edit' button:
>>
>> [Add] [Edit] [Remove]
>>
>> We don't need 'Edit' here, but why not just add the button right next
>> to the 'Create: Directory' button?
>> What's the rationale of moving the remove button to a menu on the
>> right-hand side?
> Because I think it would be better if it looks the same in pve & pbs.
> I think the reason for the menu in pve is that it is more difficult to
> accidentally remove a directory.
Ah yes, you are right, I didn't compare it to PVE. In that case it's
probably fine and you can keep it that way.
--
- Lukas
next prev parent reply other threads:[~2023-10-10 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 6:39 [pbs-devel] [PATCH proxmox-backup 1/2] cli: add option to remove systemd mount unit Markus Frank
2023-10-10 6:39 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: add Remove button for DirectoryList Markus Frank
2023-10-10 8:43 ` Lukas Wagner
2023-10-10 9:05 ` Markus Frank
2023-10-10 9:13 ` Lukas Wagner [this message]
2023-10-10 8:43 ` [pbs-devel] [PATCH proxmox-backup 1/2] cli: add option to remove systemd mount unit Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d477856a-e63c-4c05-9c34-ec9ec5c4cc99@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox