From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: autofocus after rendering text fields for 2fa
Date: Thu, 4 Feb 2021 16:11:58 +0100 [thread overview]
Message-ID: <d3f15fe5-9e6a-926b-b3a7-15778feb63fa@proxmox.com> (raw)
In-Reply-To: <20210204143930.917664-1-o.bektas@proxmox.com>
On 04.02.21 15:39, Oguz Bektas wrote:
> also fix a small typo
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> www/LoginView.js | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/www/LoginView.js b/www/LoginView.js
> index 15373533..5e8b2f93 100644
> --- a/www/LoginView.js
> +++ b/www/LoginView.js
> @@ -525,6 +525,11 @@ Ext.define('PBS.login.TfaWindow', {
> allowBlank: false,
> regex: /^[0-9]{6}$/,
> regexText: 'TOTP codes consist of six decimal digits',
> + listeners: {
> + afterrender: function(field) {
> + field.focus();
> + },
> + },
arrow functions are much nicer for such things:
listeners: {
afterrender: field => field.focus(),
},
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions
Besides that, this could be added to the existing controllers 'field' control
instance, it's not really nice to have the control logic split.
I did not test it, but if the following works you get +1 not +10 lines of change:
diff --git a/www/LoginView.js b/www/LoginView.js
index f7380339..54bc8de0 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -338,6 +338,7 @@ Ext.define('PBS.login.TfaWindow', {
// non-visible tab, so we can just directly use the valid param
this.getViewModel().set('canConfirm', valid);
},
+ afterrender: field => field.focus(), // ensure focus on initial render
},
},
> },
> ],
> },
> @@ -551,7 +556,12 @@ Ext.define('PBS.login.TfaWindow', {
> reference: 'recoveryKey',
> allowBlank: false,
> regex: /^[0-9a-f]{4}(-[0-9a-f]{4}){3}$/,
> - regexText: 'Does not looks like a valid recovery key',
> + regexText: 'Does not look like a valid recovery key',
we may also want to wrap that in gettext() for translation availability
(separate patch please)
> + listeners: {
> + afterrender: function(field) {
> + field.focus();
same here.
> + },
> + },
> },
> {
> xtype: 'box',
>
prev parent reply other threads:[~2021-02-04 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 14:39 Oguz Bektas
2021-02-04 15:11 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f15fe5-9e6a-926b-b3a7-15778feb63fa@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox