Re: [pbs-devel] [PATCH proxmox-backup/pwt 0/14] fix #5379: introduce default auth realm option

[Lukas Wagner <l.wagner@proxmox.com>]

On  2024-07-16 15:44, Christoph Heiss wrote:
> Fixes #5379 [0].
> 
> First, it adds an updatable `default` field to all existing editable
> realms. Then it converts the PAM and PBS built-in realms to proper
> realms, instead of being hard-coded in-between somewhere. 
> In turns this enables editing of these realms, allowing setting whether
> these realms should be the default for login or not.
> 
> For proxmox-widget-toolkit, the first four patches could in principal be
> applied on their own. The others depend on the API changes as introduced
> in the proxmox-backup part.
> 
> W.r.t. to applying, proxmox-backup will need a bump of
> proxmox-widget-toolkit afterwards.

Codewise it looks good (apart from some tiny tiny nits), so consider this:

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>

I also tested this on the latest master branch. Here is what I did:
 - Set the PBS realm as default
 - Add a new user to the PBS realm, for good measure
 - Logout
 - Make sure PBS is selected on the login page

I found that once you select PAM again and log in as root, the PAM realm will
be selected on next login again (even though 'save user' is not selected).
This seems to happen because the ext-pbs-pveloginrealm:"o%3Avalue%3Ds%253Apam"
key is set in local storage. If that one is cleared, it works again.
So it seems like we are interfering with the statefulness of the login widget.

Could you check if you can reproduce that?

-- 
- Lukas


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel