* [pbs-devel] [PATCH proxmox-backup] fix: tape ui: unset `deleteEmpty` in `TapeBackupWindow`
@ 2024-04-05 14:12 Stefan Sterz
2024-04-25 8:37 ` Stefan Sterz
2024-04-25 9:49 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Sterz @ 2024-04-05 14:12 UTC (permalink / raw)
To: pbs-devel
since the api rejects unknown parameters, deleteEmpty needs to be
unset here, because the endpoint for creating backups does not support
deleting parameters. otherwise a user will get a fairly cryptic error
message in the gui.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
www/tape/window/TapeBackup.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/tape/window/TapeBackup.js b/www/tape/window/TapeBackup.js
index 941b6b83..4c027ab0 100644
--- a/www/tape/window/TapeBackup.js
+++ b/www/tape/window/TapeBackup.js
@@ -39,6 +39,7 @@ Ext.define('PBS.TapeManagement.TapeBackupWindow', {
fieldLabel: gettext('Max Depth'),
disabled: true,
name: 'max-depth',
+ deleteEmpty: false,
},
{
xtype: 'pbsMediaPoolSelector',
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup] fix: tape ui: unset `deleteEmpty` in `TapeBackupWindow`
2024-04-05 14:12 [pbs-devel] [PATCH proxmox-backup] fix: tape ui: unset `deleteEmpty` in `TapeBackupWindow` Stefan Sterz
@ 2024-04-25 8:37 ` Stefan Sterz
2024-04-25 9:49 ` [pbs-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Sterz @ 2024-04-25 8:37 UTC (permalink / raw)
To: Stefan Sterz, pbs-devel
On Fri Apr 5, 2024 at 4:12 PM CEST, Stefan Sterz wrote:
> since the api rejects unknown parameters, deleteEmpty needs to be
> unset here, because the endpoint for creating backups does not support
> deleting parameters. otherwise a user will get a fairly cryptic error
> message in the gui.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> www/tape/window/TapeBackup.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/tape/window/TapeBackup.js b/www/tape/window/TapeBackup.js
> index 941b6b83..4c027ab0 100644
> --- a/www/tape/window/TapeBackup.js
> +++ b/www/tape/window/TapeBackup.js
> @@ -39,6 +39,7 @@ Ext.define('PBS.TapeManagement.TapeBackupWindow', {
> fieldLabel: gettext('Max Depth'),
> disabled: true,
> name: 'max-depth',
> + deleteEmpty: false,
> },
> {
> xtype: 'pbsMediaPoolSelector',
ping, this is a fairly minor improvement that fixes the one of tape
backup ui
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] fix: tape ui: unset `deleteEmpty` in `TapeBackupWindow`
2024-04-05 14:12 [pbs-devel] [PATCH proxmox-backup] fix: tape ui: unset `deleteEmpty` in `TapeBackupWindow` Stefan Sterz
2024-04-25 8:37 ` Stefan Sterz
@ 2024-04-25 9:49 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-04-25 9:49 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Stefan Sterz
Am 05/04/2024 um 16:12 schrieb Stefan Sterz:
> since the api rejects unknown parameters, deleteEmpty needs to be
> unset here, because the endpoint for creating backups does not support
> deleting parameters. otherwise a user will get a fairly cryptic error
> message in the gui.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> www/tape/window/TapeBackup.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-25 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-05 14:12 [pbs-devel] [PATCH proxmox-backup] fix: tape ui: unset `deleteEmpty` in `TapeBackupWindow` Stefan Sterz
2024-04-25 8:37 ` Stefan Sterz
2024-04-25 9:49 ` [pbs-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox