From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] ui: show (local)datastore column only in global sync/verifyview
Date: Tue, 10 Nov 2020 13:24:40 +0100 [thread overview]
Message-ID: <d123accb-003e-fd3c-d66f-09a3b8b14e3d@proxmox.com> (raw)
In-Reply-To: <20201110115800.30900-1-d.csapak@proxmox.com>
On 10.11.20 12:58, Dominik Csapak wrote:
> its rather hacky, but our cbind mixin does not support columns (yet).
> if it does sometime in the future, we could use that instead
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/config/SyncView.js | 9 +++++++++
> www/config/VerifyView.js | 14 ++++++++++++++
> 2 files changed, 23 insertions(+)
>
>
applied, thanks! Follow'd up with changing this to a slightly less hard coded
way, hoping that dataIndex does not changes as often as a column reordering,
addition, or deletion may happen.
for (let column of me.columns) {
if (column.dataIndex === 'store') {
column.hidden = hideLocalDatastore;
break;
}
}
prev parent reply other threads:[~2020-11-10 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 11:58 [pbs-devel] " Dominik Csapak
2020-11-10 12:24 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d123accb-003e-fd3c-d66f-09a3b8b14e3d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox