From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v5 proxmox-backup 7/8] ui: expose GC atime cutoff in datastore tuning option
Date: Wed, 19 Mar 2025 09:49:23 +0100 [thread overview]
Message-ID: <d0dd298a-aa34-4fa3-b4d7-9dc0a62fdf87@proxmox.com> (raw)
In-Reply-To: <20250306145252.565270-8-c.ebner@proxmox.com>
Am 06.03.25 um 15:52 schrieb Christian Ebner:
> Allows to set the atime cutoff for phase 2 of garbage collection in
> the datastores tuning parameters. This value changes the time after
> which a chunk is not considered in use anymore if it falls outside of
> the cutoff window.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 4:
> - no changes
>
> www/Utils.js | 5 +++++
> www/datastore/OptionView.js | 9 +++++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/www/Utils.js b/www/Utils.js
> index 9bd7e1615..13b5eceda 100644
> --- a/www/Utils.js
> +++ b/www/Utils.js
> @@ -850,6 +850,11 @@ Ext.define('PBS.Utils', {
> delete tuning['gc-atime-safety-check'];
> options.push(`${gettext('GC Access Time Safety Check')}: ${gc_atime_safety_check ?? true}`);
>
> + let gc_atime_cutoff = tuning['gc-atime-cutoff'];
> + delete tuning['gc-atime-cutoff'];
> + gc_atime_cutoff = gc_atime_cutoff ?? '1445';
> + options.push(`${gettext('GC Access Time Cutoff')}: ${gc_atime_cutoff}m`);
> +
> for (const [k, v] of Object.entries(tuning)) {
> options.push(`${k}: ${v}`);
> }
> diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
> index 9ce3ce388..9e8dcc4fb 100644
> --- a/www/datastore/OptionView.js
> +++ b/www/datastore/OptionView.js
> @@ -279,6 +279,15 @@ Ext.define('PBS.Datastore.Options', {
> uncheckedValue: 0,
> deleteDefaultValue: true,
> },
> + {
> + xtype: 'proxmoxintegerfield',
> + emptyText: Proxmox.Utils.defaultText,
This won't change that soon I think, so we could convey the actual default
value, like e.g.:
gettext('1445 (24 hours 5 minutes)'),
> + name: 'gc-atime-cutoff',
tiny nit, I prefer ordering of properties such that xtype and name come first,
as normally those are the most important options w.r.t. what this is and how
it will be submitted. It's nice to get the label then afterward, but way less
hard feelings there.
> + minValue: 1,
> + maxValue: 2880,
> + fieldLabel: gettext('GC Access Time Cutoff (min)'),
> + deleteEmpty: true,
> + },
> ],
> },
> },
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-03-19 8:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 14:52 [pbs-devel] [PATCH v5 proxmox-backup 0/8] fix #5982: check atime update is honored Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox 1/8] pbs api types: add garbage collection atime safety check flag Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox 2/8] pbs api types: add option to set GC chunk cleanup atime cutoff Christian Ebner
2025-03-19 8:10 ` Thomas Lamprecht
2025-03-19 8:48 ` Christian Ebner
2025-03-19 9:01 ` Thomas Lamprecht
2025-03-19 9:08 ` Christian Ebner
2025-03-19 9:13 ` Thomas Lamprecht
2025-03-19 9:25 ` Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 3/8] fix #5982: garbage collection: check atime updates are honored Christian Ebner
2025-03-19 8:45 ` Thomas Lamprecht
2025-03-19 9:22 ` Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 4/8] ui: expose GC atime safety check flag in datastore tuning options Christian Ebner
2025-03-19 8:45 ` Thomas Lamprecht
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 5/8] docs: mention GC atime update check for " Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 6/8] datastore: use custom GC atime cutoff if set Christian Ebner
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 7/8] ui: expose GC atime cutoff in datastore tuning option Christian Ebner
2025-03-19 8:49 ` Thomas Lamprecht [this message]
2025-03-06 14:52 ` [pbs-devel] [PATCH v5 proxmox-backup 8/8] docs: mention gc-atime-cutoff as " Christian Ebner
2025-03-19 17:26 ` [pbs-devel] [PATCH v5 proxmox-backup 0/8] fix #5982: check atime update is honored Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0dd298a-aa34-4fa3-b4d7-9dc0a62fdf87@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal