From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 0/8] improve datstore ux
Date: Tue, 27 Oct 2020 17:55:45 +0100 [thread overview]
Message-ID: <d0db1015-327e-c10b-658b-91f7d285132f@proxmox.com> (raw)
In-Reply-To: <20201027152011.7373-1-d.csapak@proxmox.com>
On 27.10.20 16:20, Dominik Csapak wrote:
> this series aims to improve the datastore ux by
> * moving all datastore relevant settings/options/views into the
> datastore tabpanel
> * adding a 'Summary' panel with some important information
> * improving tab selection between datastores/browser reloads/etc.
>
> this needs my previous series: "improve and extend admin/datastore/status api"
> to work
>
> some things are still to be improved, namely:
> * multiline comments for datastores
> * automatic ids for sync/verify jobs
> * improved prune/gc panel (e.g. with status of last run)
> * comments for backup snapshots
>
> Dominik Csapak (8):
> api/{verify,syncjobs}: add optional datastore parameter
> ui: DataStoreContent: add 'Verify All' button
> ui: add DataStorePruneAndGC panel and add it to datastore panel
> ui: add DataStoreSummary and move Statistics into it
> ui: move sync/verify jobs to the datastores
> ui: NavigationTree: add 'Add Datastore' button below datastore list
> ui: MainView/NavigationTree: improve tree selection handling
> ui: DataStorePanel: save active tab statefully
>
> src/api2/admin/sync.rs | 19 ++-
> src/api2/admin/verify.rs | 19 ++-
> www/DataStoreContent.js | 23 +++
> www/DataStoreNotes.js | 104 ++++++++++++
> www/DataStorePanel.js | 52 +++++-
> www/DataStorePruneAndGC.js | 164 +++++++++++++++++++
> www/DataStoreStatistic.js | 104 ------------
> www/DataStoreSummary.js | 296 ++++++++++++++++++++++++++++++++++
> www/MainView.js | 70 ++++----
> www/Makefile | 5 +-
> www/NavigationTree.js | 101 ++++++++----
> www/config/DataStoreConfig.js | 227 --------------------------
> www/config/SyncView.js | 14 +-
> www/config/VerifyView.js | 20 ++-
> www/window/DataStoreEdit.js | 147 +++++++++--------
> www/window/SyncJobEdit.js | 6 +-
> www/window/VerifyJobEdit.js | 6 +-
> 17 files changed, 898 insertions(+), 479 deletions(-)
> create mode 100644 www/DataStoreNotes.js
> create mode 100644 www/DataStorePruneAndGC.js
> delete mode 100644 www/DataStoreStatistic.js
> create mode 100644 www/DataStoreSummary.js
> delete mode 100644 www/config/DataStoreConfig.js
>
applied series, much thanks! FYI, pushed the following small patches on top:
ui: datastore summary: clarify that it's a deduplication factor
ui: datastore: used fixed-width icons for summary
ui: datastore: change GC/Prune title and buttons a bit
ui: datastore: add confirmation message to verify all
Some possible additions and thoughts:
* warning on summary if no GC, prune or verify job is configured (especially verify should
be an warning-triangle, the other could be "notice-exclamation-mark" level)
* The "Removed Bytes" in the summary is a bit strange to me, I'd rather drop it
* make the backup count thing aligned like a table, with the Groups and Snapshots as column
header, and maybe a "Total" row at the end with all summed up
* not sure where we'd put the only recently added "verify_new" datastore option, it could be
possible to rename "Verify Jobs" to "Verification" and add a option panel over the jobs one,
would only host that setting for now, though.
* onlineHelp buttons for all panels and their edit dialogs please (@Dylan, @Oguz, @all)
prev parent reply other threads:[~2020-10-27 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 15:20 [pbs-devel] " Dominik Csapak
2020-10-27 15:20 ` [pbs-devel] [PATCH proxmox-backup 1/8] api/{verify, syncjobs}: add optional datastore parameter Dominik Csapak
2020-10-27 15:20 ` [pbs-devel] [PATCH proxmox-backup 2/8] ui: DataStoreContent: add 'Verify All' button Dominik Csapak
2020-10-27 15:20 ` [pbs-devel] [PATCH proxmox-backup 3/8] ui: add DataStorePruneAndGC panel and add it to datastore panel Dominik Csapak
2020-10-27 15:20 ` [pbs-devel] [PATCH proxmox-backup 4/8] ui: add DataStoreSummary and move Statistics into it Dominik Csapak
2020-10-27 15:20 ` [pbs-devel] [PATCH proxmox-backup 5/8] ui: move sync/verify jobs to the datastores Dominik Csapak
2020-10-27 15:20 ` [pbs-devel] [PATCH proxmox-backup 6/8] ui: NavigationTree: add 'Add Datastore' button below datastore list Dominik Csapak
2020-10-27 15:20 ` [pbs-devel] [PATCH proxmox-backup 7/8] ui: MainView/NavigationTree: improve tree selection handling Dominik Csapak
2020-10-27 15:20 ` [pbs-devel] [PATCH proxmox-backup 8/8] ui: DataStorePanel: save active tab statefully Dominik Csapak
2020-10-27 16:55 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0db1015-327e-c10b-658b-91f7d285132f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox