From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied-series: [PATCH pxar 0/3] pxar: make payload reference offset checks stricter
Date: Wed, 27 Aug 2025 14:36:28 +0200 [thread overview]
Message-ID: <cwksm3zemnlyyduiyjvehu5iyzofleybvysf4vqtq35tgwq4dn@xclty3yvtd4f> (raw)
In-Reply-To: <20250827094633.239975-1-c.ebner@proxmox.com>
applied, thanks
On Wed, Aug 27, 2025 at 11:46:30AM +0200, Christian Ebner wrote:
> This patch series aims to block the encoding of possible corrupt split
> pxar archives due to the payload reference offsets not being strict
> monotonically increasing. This is a requirement for the sequential
> decoder to be able to restore the contents from a sequential stream.
>
> This should also help to detect more corrupt encodings as reported in
> the community forum and therefore narrow down the still lingering
> logical issue, still under investigation.
>
> First two patches are style cleanups only, the third contains the
> stricter encoder check.
>
> [0] https://forum.proxmox.com/threads/170211/
>
> pxar:
>
> Christian Ebner (3):
> tree wide: fix formatting via `cargo fmt`
> tree wide: elide explicit lifetimes reported by cargo clippy
> encoder: improve consistency check for payload reference offsets
>
> examples/pxarcmd.rs | 2 +-
> src/accessor/aio.rs | 4 +--
> src/accessor/mod.rs | 6 ++--
> src/accessor/read_at.rs | 6 ++--
> src/accessor/sync.rs | 8 ++---
> src/decoder/aio.rs | 2 +-
> src/decoder/mod.rs | 6 ++--
> src/decoder/sync.rs | 2 +-
> src/encoder/aio.rs | 4 +--
> src/encoder/mod.rs | 76 +++++++++++++++++++++++++++++------------
> src/encoder/sync.rs | 4 +--
> src/lib.rs | 2 +-
> tests/compat.rs | 2 +-
> tests/simple/fs.rs | 8 ++---
> tests/simple/main.rs | 4 +--
> 15 files changed, 85 insertions(+), 51 deletions(-)
>
>
> Summary over all repositories:
> 15 files changed, 85 insertions(+), 51 deletions(-)
>
> --
> Generated by git-murpp 0.8.1
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-08-27 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 9:46 [pbs-devel] " Christian Ebner
2025-08-27 9:46 ` [pbs-devel] [PATCH pxar 1/3] tree wide: fix formatting via `cargo fmt` Christian Ebner
2025-08-27 9:46 ` [pbs-devel] [PATCH pxar 2/3] tree wide: elide explicit lifetimes reported by cargo clippy Christian Ebner
2025-08-27 9:46 ` [pbs-devel] [PATCH pxar 3/3] encoder: improve consistency check for payload reference offsets Christian Ebner
2025-08-27 12:36 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cwksm3zemnlyyduiyjvehu5iyzofleybvysf4vqtq35tgwq4dn@xclty3yvtd4f \
--to=w.bumiller@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox