From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: Outsource the logger initialization to the router
Date: Fri, 29 Sep 2023 11:35:06 +0200 [thread overview]
Message-ID: <cf4369be-147c-46a9-a332-6b3cbb18f500@proxmox.com> (raw)
In-Reply-To: <20230821111938.110298-1-g.goller@proxmox.com>
high level comment:
is proxmox-router really the right place for this?
IMHO where we want to log to should be decided by each binary/daemon/utility etc. and
not in the crate responsible for routing api requests?
It would at least be better if it would be it's own crate (e.g. proxmox-log ?)
I just say this because if we want to rework the logging from workers (which
live in proxmox-rest-server) this could complicate things
(though i did not spend too much time thinking what the possible issues could be)
whats your opinion on that @wolfgang, @thomas?
next prev parent reply other threads:[~2023-09-29 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 11:19 Gabriel Goller
2023-08-21 11:19 ` [pbs-devel] [PATCH proxmox] router: Added `init_syslog_logger()` function Gabriel Goller
2023-09-29 8:47 ` [pbs-devel] [PATCH proxmox-backup] api: Outsource the logger initialization to the router Gabriel Goller
2023-09-29 9:35 ` Dominik Csapak [this message]
2023-09-29 9:49 ` Wolfgang Bumiller
2023-09-29 10:23 ` Dominik Csapak
2023-09-29 11:09 ` Gabriel Goller
2023-09-29 11:46 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf4369be-147c-46a9-a332-6b3cbb18f500@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox