From: Christian Ebner <c.ebner@proxmox.com>
To: Jakob-Tobias Winter <tobias@stuttgart.de>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v2] tape: virtual drive: fix endless recursion in changer status
Date: Thu, 12 Nov 2026 10:15:11 +0100 [thread overview]
Message-ID: <cf3140c8-b5f2-45fb-9716-3dc5ed0123a1@proxmox.com> (raw)
In-Reply-To: <20261111204853.531985-2-tobias@stuttgart.de>
On 11/11/26 9:49 PM, Jakob-Tobias Winter wrote:
> The virtual tape drive, which exists for tests and debugging only, also
> acts as its own changer and reports every virtual tape in its directory
> as a slot. To build that status it asks for the list of online media.
> The drive has its own way to get that list, the tapes in its directory,
> but that was kept next to the changer interface instead of being part of
> it. So the status got the generic variant of the list, which is derived
> from the changer status. The two called each other until the stack
> overflowed, and every operation that needs the changer status of a
> virtual drive, like loading or unloading a tape, crashed the process.
>
> Make the list of tapes in the directory the variant that the changer
> interface of the virtual drive provides, so that it replaces the generic
> one for the status and for loading a tape from a slot.
>
> Fixes: 46a1863f8 ("tape: improve MediaChange trait")
> Suggested-by: Christian Ebner <c.ebner@proxmox.com>
> Signed-off-by: Jakob-Tobias Winter <tobias@stuttgart.de>
Thanks for the revised version of the patch!
This is the correct approach for the fix and matches what I've come up
with during review of version 1.
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
next prev parent reply other threads:[~2026-11-12 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 20:48 [PATCH proxmox-backup v2] tape: virtual drive: fix endless recursion in changer status Jakob-Tobias Winter
2026-11-12 9:15 ` Christian Ebner [this message]
2026-11-14 21:27 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3140c8-b5f2-45fb-9716-3dc5ed0123a1@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=tobias@stuttgart.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox