From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v5 5/5] fix #3067: ui: add a separate notes view for longer markdown notes
Date: Mon, 25 Apr 2022 11:44:27 +0200 [thread overview]
Message-ID: <cd097ebe-f975-c862-c374-89db6c3af399@proxmox.com> (raw)
In-Reply-To: <20220412103423.3845322-6-s.sterz@proxmox.com>
On 12.04.22 12:34, Stefan Sterz wrote:
> since markdown notes might be rather long, this commit adds a tab
> similar to pve's datacenter or node notes. requires a bump of the
> widget toolkit in order to use the `pmxNotesView`.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> i chose the maxLength of a note in pbs to be 1022*64 because the
> server allows at most 1024*64 bytes of form data per request, which
> are distributed as follows:
>
> equal signs: 2
> the word "digest": 7
> digest: 64
> the word "description": 12
> description: 65451
>
> so by setting the limit to 1024*64 some users might encounter an
> error telling them that the message body was too large even though the
> front-end said the description was fine. i wanted to approximate
> the 1024*64 limit here as close as possible so i chose:
> 65451 / 64 ~ 1022.
>
> note that afaict due to the way maxLength is implemented the frontend
> might not report an error when it should. this is due to character
> encodings and how javascript's string length property works.
>
> www/Makefile | 1 +
> www/NavigationTree.js | 6 ++++++
> www/NodeNotes.js | 23 +++++++++++++++++++++++
> 3 files changed, 30 insertions(+)
> create mode 100644 www/NodeNotes.js
>
>
applied, thanks!
prev parent reply other threads:[~2022-04-25 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 10:34 [pbs-devel] [PATCH proxmox-backup v5 0/5] fix 3067: add notes functionality in webui Stefan Sterz
2022-04-12 10:34 ` [pbs-devel] [PATCH proxmox-backup v5 1/5] fix #3067: docs: add markdown primer from pve to pbs Stefan Sterz
2022-04-25 9:44 ` [pbs-devel] applied: " Thomas Lamprecht
2022-04-12 10:34 ` [pbs-devel] [PATCH widget-toolkit v5 2/5] toolkit: add NotesView panel and NotesEdit window Stefan Sterz
2022-04-13 9:43 ` [pbs-devel] applied: " Thomas Lamprecht
2022-04-12 10:34 ` [pbs-devel] [PATCH widget-toolkit v5 3/5] toolkit: refactor markdown based NotesView and NotesEdit Stefan Sterz
2022-04-13 9:43 ` [pbs-devel] applied: " Thomas Lamprecht
2022-04-12 10:34 ` [pbs-devel] [PATCH manager v5 4/5] ui: move NotesView panel and NotesEdit window to widget kit Stefan Sterz
2022-04-26 14:09 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2022-04-12 10:34 ` [pbs-devel] [PATCH proxmox-backup v5 5/5] fix #3067: ui: add a separate notes view for longer markdown notes Stefan Sterz
2022-04-25 9:44 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd097ebe-f975-c862-c374-89db6c3af399@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox