From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v3 00/10] s3: implement list buckets and use bucket selector for datastore creation
Date: Thu, 31 Jul 2025 15:28:51 +0200 [thread overview]
Message-ID: <ca5fa8d7-3bcd-4d1e-aecd-e72d8845f28c@proxmox.com> (raw)
In-Reply-To: <96e0fd7f-a258-4ad9-b0de-8f3774ea5870@proxmox.com>
Am 31.07.25 um 15:17 schrieb Thomas Lamprecht:
> Am 31.07.25 um 15:02 schrieb Christian Ebner:
>> superseded-by version 4:
>> https://lore.proxmox.com/pbs-devel/DBQ7YRTZE0NV.LM0ZMFK4WZR1@proxmox.com/T/
>
> I already pushed the s3 changes and just finished building the PBS one,
> can I get follow-ups please?
Maybe a bit more context, given that Lukas comments where mostly developer
experience related and signaled a positive review and me having taken
a slightly closer look at v2 already and testing was positive I started
to push this out, and when I almost was done with uploading and pushing
the PBS to git your v4 came in. FWICT it's no user facing changes where
included compared to this v3, and the test worked out nice as I could
get my buckets from both Cloudflare R2 as also Hetzner S3, nice UX
improvement.
In anyway, I just wanted to explicitly clarify that I really have no
high priority for the code improvements, as previous reply might be
understood differently.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-07-31 13:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 10:48 Christian Ebner
2025-07-31 10:48 ` [pbs-devel] [PATCH proxmox v3 1/4] s3 client: restrict bucket template pattern to start of endpoint url Christian Ebner
2025-07-31 10:48 ` [pbs-devel] [PATCH proxmox v3 2/4] s3 client: make bucket name optional in S3 client options Christian Ebner
2025-07-31 10:48 ` [pbs-devel] [PATCH proxmox v3 3/4] s3 client: implement list buckets method Christian Ebner
2025-07-31 11:43 ` Lukas Wagner
2025-07-31 10:48 ` [pbs-devel] [PATCH proxmox v3 4/4] s3 client: api types: add bucket list item type Christian Ebner
2025-07-31 10:48 ` [pbs-devel] [PATCH proxmox-backup v3 1/6] ui: fix formatting issues using proxmox-biome Christian Ebner
2025-07-31 10:48 ` [pbs-devel] [PATCH proxmox-backup v3 2/6] datastore: wrap bucket name, as in is now optional in the s3 client Christian Ebner
2025-07-31 10:48 ` [pbs-devel] [PATCH proxmox-backup v3 3/6] api: admin s3: make store prefix for check command optional Christian Ebner
2025-07-31 10:48 ` [pbs-devel] [PATCH proxmox-backup v3 4/6] api: config s3: add bucket list api endpoint Christian Ebner
2025-07-31 10:48 ` [pbs-devel] [PATCH proxmox-backup v3 5/6] bin: expose list buckets as proxmox-backup-manager s3 subcommand Christian Ebner
2025-07-31 10:48 ` [pbs-devel] [PATCH proxmox-backup v3 6/6] ui: replace bucket field by bucket selector Christian Ebner
2025-07-31 11:55 ` [pbs-devel] [PATCH proxmox{, -backup} v3 00/10] s3: implement list buckets and use bucket selector for datastore creation Lukas Wagner
2025-07-31 13:02 ` Christian Ebner
2025-07-31 13:17 ` Thomas Lamprecht
2025-07-31 13:28 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca5fa8d7-3bcd-4d1e-aecd-e72d8845f28c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox