public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Matthias Heiserer <m.heiserer@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] fix #3103. node config: allow to configure default UI language
Date: Thu, 3 Feb 2022 14:37:27 +0100	[thread overview]
Message-ID: <c9e59bcf-2b70-b9a9-d4ef-ed89df7dee0f@proxmox.com> (raw)
In-Reply-To: <20220124100950.2752861-1-m.heiserer@proxmox.com>

On 24.01.22 11:09, Matthias Heiserer wrote:
> This language is only used if none is set in the cookies.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> Changes  from v1:
>  Adhere to max length
>  Remove trailing whitespace
>  Use enum to store available translations
>  Add language name to enum variants
>  Rename chinese and portugese to same case as in i18 files
>  Check for existance of translation file when using default language
> 
>  src/bin/proxmox-backup-proxy.rs |  9 ++++
>  src/config/node.rs              | 75 ++++++++++++++++++++++++++++++++-
>  2 files changed, 82 insertions(+), 2 deletions(-)
> 
>

applied, thanks!

I dropped the need for `#[allow(non_camel_case_types)]` on the enu, as we
have a serde-rename on the affected members anyway, also cleaned up how the
proxy extracts the language stuff, as that was quite convoluted..

FYI, there's still something missing: the api is missing integration for
this in the node config update method, so setting it via API or via
`proxmox-backup-manager node update --default-language it` cannot work yet,
fixing that is quite trivial, can you please send a followup patch for that
and ideally also the GUI support?




      reply	other threads:[~2022-02-03 13:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 10:09 [pbs-devel] " Matthias Heiserer
2022-02-03 13:37 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9e59bcf-2b70-b9a9-d4ef-ed89df7dee0f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.heiserer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal