From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [RFC proxmox-backup 2/2] GC: add check for nested datastore
Date: Wed, 27 Nov 2024 15:31:31 +0100 [thread overview]
Message-ID: <c7c5e098-915b-4843-93be-71fb259bcf2f@proxmox.com> (raw)
In-Reply-To: <20241127141128.1123925-2-f.gruenbichler@proxmox.com>
Am 27.11.24 um 15:11 schrieb Fabian Grünbichler:
> these are particularly problematic since GC will walk the whole datastore tree
> on the file system, and will thus pick up indices (but not chunks!) from nested
> directories that are ignored in other code paths that use our regular
> iterators..
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> a similar check might also be sensible for mounting and should now be fairly
> easy to implement there as well..
>
> pbs-datastore/src/datastore.rs | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>
applied, thanks!
It's a sensible improvement and cost is low, especially compared to what GC does
in general. That said, it's naturally not a silver bullet, through a symlink or
bind mount one could construct a datastore that would not be detected, but
probably obvious to you already so just mentioning for the sake of completeness.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-27 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 14:11 [pbs-devel] [PATCH proxmox-backup 1/2] datastore: extract nesting check into helper Fabian Grünbichler
2024-11-27 14:11 ` [pbs-devel] [RFC proxmox-backup 2/2] GC: add check for nested datastore Fabian Grünbichler
2024-11-27 14:31 ` Thomas Lamprecht [this message]
2024-11-27 14:27 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] datastore: extract nesting check into helper Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7c5e098-915b-4843-93be-71fb259bcf2f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox