Re: [PATCH proxmox v5 13/13] s3-client: implement request counter threshold and exceeding callback

[Hannes Laimer <h.laimer@proxmox.com>]

On 2026-03-11 14:09, Christian Ebner wrote:
> Allows to set the threshold values to trigger exceeding callbacks
> for the s3 request counters.
> The globally settable callback function is executed whenever one of
> the request counters is exceeding it's set threshold value, but
> only once when passing over the threshold.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---

[..]

>      /// Returns upload traffic count.
> @@ -109,13 +170,51 @@ impl RequestCounters {
>      ///
>      /// Returns the previously stored value.
>      pub fn add_download_traffic(&self, count: u64, ordering: Ordering) -> u64 {
> -        self.download.0.fetch_add(count, ordering)
> +        let prev = self.download.0.fetch_add(count, ordering);
> +        let threshold = self.upload_threshold.0.load(Ordering::Acquire);

small typo, should be `download_threshold`

> +        let downloaded = prev + count;
> +        if threshold > 0 && downloaded > threshold && prev <= threshold {
> +            let guard = SHARED_COUNTER_THRESHOLD_EXCEEDED_CALLBACK.read().unwrap();
> +            if let Some(callback) = guard.as_ref() {
> +                callback("downloaded", threshold, downloaded);
> +            }
> +        }
> +        prev
>      }

[..]