From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH v5 proxmox-widget-toolkit 0/5] add LDAP realm support UI
Date: Fri, 17 Mar 2023 16:45:24 +0100 [thread overview]
Message-ID: <c6828bb2-4449-8c92-50c3-a588192ed6b1@proxmox.com> (raw)
In-Reply-To: <20230317084722.106090-1-l.wagner@proxmox.com>
On 17/03/2023 09:47, Lukas Wagner wrote:
> This patch series adds support for adding LDAP realms, including user sync.
>
> The GUI is mostly based on the implementation from PVE, with some slight
> adaptations - for details, please refer to the commit messages.
> The GUI components were added to the widget-toolkit repo, at some point PVE
> could be adapted to use the same implemention as PBS.
>
> Changes v4 --> v5:
> * No content changes, just rebased to current master as the patches
> did not apply cleanly anymore
>
> Changes v3 --> v4:
> * use the `let me = this` pattern in the sync ui - strictly it is not needed,
> but it may prevent errors if the code is ever modified.
> * Fix bug reported by Friedrich [1], where a particular combination of
> attributes could trigger a `value not defined in enumeration` error
>
> Changes v2 --> v3:
> * no changes in the UI patches
> Changes v1 --> v2:
> * no changes in the UI patches
>
> [1] https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005938.html
>
> Versions:
>
> v1: https://lists.proxmox.com/pipermail/pbs-devel/2023-January/005788.html
> v2: https://lists.proxmox.com/pipermail/pbs-devel/2023-January/005844.html
> v3: https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005914.html
> v4: https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005953.html
>
>
> Lukas Wagner (5):
> auth ui: add LDAP realm edit panel
> auth ui: add LDAP sync UI
> auth ui: add `onlineHelp` for AuthEditLDAP
> auth ui: add `firstname` and `lastname` sync-attribute fields
> auth ui: fix `value not defined in enumeration` error
>
> src/Makefile | 2 +
> src/Schema.js | 12 ++
> src/panel/AuthView.js | 24 +++
> src/window/AuthEditLDAP.js | 376 +++++++++++++++++++++++++++++++++++++
> src/window/SyncWindow.js | 192 +++++++++++++++++++
> 5 files changed, 606 insertions(+)
> create mode 100644 src/window/AuthEditLDAP.js
> create mode 100644 src/window/SyncWindow.js
>
applied series, albeit I did not went for a full new in-depth review as this
is currently not used and bases a lot on the quite well working code of PVE,
so we can fix any nit/bug that turns up when we actually use it in PBS or
switch the implementation over in PVE, thanks!
prev parent reply other threads:[~2023-03-17 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 8:47 [pbs-devel] " Lukas Wagner
2023-03-17 8:47 ` [pbs-devel] [PATCH v5 proxmox-widget-toolkit 1/5] auth ui: add LDAP realm edit panel Lukas Wagner
2023-03-17 8:47 ` [pbs-devel] [PATCH v5 proxmox-widget-toolkit 2/5] auth ui: add LDAP sync UI Lukas Wagner
2023-03-17 8:47 ` [pbs-devel] [PATCH v5 proxmox-widget-toolkit 3/5] auth ui: add `onlineHelp` for AuthEditLDAP Lukas Wagner
2023-03-17 8:47 ` [pbs-devel] [PATCH v5 proxmox-widget-toolkit 4/5] auth ui: add `firstname` and `lastname` sync-attribute fields Lukas Wagner
2023-03-17 8:47 ` [pbs-devel] [PATCH v5 proxmox-widget-toolkit 5/5] auth ui: fix `value not defined in enumeration` error Lukas Wagner
2023-03-17 15:45 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6828bb2-4449-8c92-50c3-a588192ed6b1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox