public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] docs: fix references to changed refs
Date: Sat, 6 Feb 2021 09:12:56 +0100	[thread overview]
Message-ID: <c5714c66-cd31-fd92-b486-caab3a1eda8a@proxmox.com> (raw)
In-Reply-To: <20210205151030.28946-1-a.lauterer@proxmox.com>

On 05.02.21 16:10, Aaron Lauterer wrote:
> With commit ec1ae7e63180768c9ad8fa52d437a1cee6ef1c50 some refs were
> changed by getting prefixes and such. We need to adapt the places that
> reference them as well

The commit messages forgets to mention that underlying issue here is that
the build still happily succeeds, which it really must not.

sphinx-builder can make treat warnings as errors, but there are so many
(especially from generated man pages and such) that this is unpractical.

What we actually can do is listening to the missing reference event and
abort the build our self:

https://www.sphinx-doc.org/de/latest/extdev/appapi.html#event-missing-reference




      parent reply	other threads:[~2021-02-06  8:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 15:10 Aaron Lauterer
2021-02-05 15:10 ` [pbs-devel] [PATCH proxmox-backup 2/2] docs/scanrefs: fix handling if ref is same as headline Aaron Lauterer
2021-02-06  8:22   ` Thomas Lamprecht
2021-02-08 16:06     ` Aaron Lauterer
2021-02-06  7:49 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] docs: fix references to changed refs Dietmar Maurer
2021-02-06  8:12 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5714c66-cd31-fd92-b486-caab3a1eda8a@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal