From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup 2/2] ui: GC/prune: pass tasks last run endtime to task viewer
Date: Mon, 4 May 2026 10:02:49 +0200 [thread overview]
Message-ID: <c5360742-999b-4388-9bb0-f08715718b41@proxmox.com> (raw)
In-Reply-To: <20260430121015.528664-3-c.ebner@proxmox.com>
Am 30.04.26 um 14:09 schrieb Christian Ebner:
> Same issue as tackled by commit e8552dae3 ("ui: sync/verify view:
> show correct duration in task log window"), pass the last run
> endtime to the task log window for correct calculation of the
> job duration for finished jobs, not using the current time.
>
> For correctly showing the verification task status in datastore
> contents, an additional API request is required first to get the
> endtime. Other call sites arelady have the required information.
>
> Fixes: https://forum.proxmox.com/threads/183157/
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
AFAICT this can be handled in widget-toolkit without extra (blocking)
calls here on api task open, as it shouldn't hurt I pushed out already
a proposed change here:
https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=7431c0766f0439481ae17ef54f49ee8edc210069
next prev parent reply other threads:[~2026-05-04 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 12:10 [PATCH proxmox-backup 0/2] additional task endtime fixes Christian Ebner
2026-04-30 12:10 ` [PATCH proxmox-backup 1/2] api: node: return optional endtime in tasks status Christian Ebner
2026-04-30 12:10 ` [PATCH proxmox-backup 2/2] ui: GC/prune: pass tasks last run endtime to task viewer Christian Ebner
2026-05-04 6:34 ` Dominik Csapak
2026-05-04 7:04 ` Christian Ebner
2026-05-04 8:02 ` Thomas Lamprecht [this message]
2026-05-04 8:11 ` Christian Ebner
2026-05-04 15:45 ` superseded: [PATCH proxmox-backup 0/2] additional task endtime fixes Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5360742-999b-4388-9bb0-f08715718b41@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox