public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [RFC PATCH proxmox 2/4] promxox-router: add SerializableReturn Trait
Date: Fri, 18 Feb 2022 09:21:14 +0100	[thread overview]
Message-ID: <c4958ba7-26ee-b2b2-95b0-8f797a1982ff@proxmox.com> (raw)
In-Reply-To: <20220217094041.1632033-3-d.csapak@proxmox.com>

I guess we do not want to depend on proxmox-async here - this adds to 
many unnecessary dependencies!

On 2/17/22 10:40, Dominik Csapak wrote:
> this will be useful as a generic return type for api calls which
> must implement Serialize.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   proxmox-router/Cargo.toml                 |  2 +
>   proxmox-router/src/lib.rs                 |  2 +
>   proxmox-router/src/serializable_return.rs | 62 +++++++++++++++++++++++
>   3 files changed, 66 insertions(+)
>   create mode 100644 proxmox-router/src/serializable_return.rs
>
> diff --git a/proxmox-router/Cargo.toml b/proxmox-router/Cargo.toml
> index 28616d8..d460772 100644
> --- a/proxmox-router/Cargo.toml
> +++ b/proxmox-router/Cargo.toml
> @@ -15,6 +15,7 @@ hyper = { version = "0.14", features = [ "full" ] }
>   nix = "0.19.1"
>   percent-encoding = "2.1"
>   serde_json = "1.0"
> +serde = "1.0"
>   unicode-width ="0.1.8"
>   
>   # cli:
> @@ -24,6 +25,7 @@ libc = { version = "0.2", optional = true }
>   
>   proxmox-lang = { path = "../proxmox-lang", version = "1.0" }
>   proxmox-schema = { path = "../proxmox-schema", version = "1.1" }
> +proxmox-async = { path = "../proxmox-async", version = "0.3" }




  reply	other threads:[~2022-02-18  8:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17  9:40 [pbs-devel] [RFC PATCH proxmox/proxmox-backup] implement streaming serialization for api calls Dominik Csapak
2022-02-17  9:40 ` [pbs-devel] [RFC PATCH proxmox 1/4] proxmox-async: add SenderWriter helper Dominik Csapak
2022-02-17  9:40 ` [pbs-devel] [RFC PATCH proxmox 2/4] promxox-router: add SerializableReturn Trait Dominik Csapak
2022-02-18  8:21   ` Dietmar Maurer [this message]
2022-02-17  9:40 ` [pbs-devel] [RFC PATCH proxmox 3/4] proxmox-router: add new ApiHandler variants for streaming serialization Dominik Csapak
2022-02-17  9:40 ` [pbs-devel] [RFC PATCH proxmox 4/4] proxmox-api-macro: add 'streaming' option Dominik Csapak
2022-02-17  9:40 ` [pbs-devel] [RFC PATCH proxmox-backup 1/3] proxmox-rest-server: OutputFormatter: add new format_data_streaming method Dominik Csapak
2022-02-23  9:20   ` Thomas Lamprecht
2022-02-17  9:40 ` [pbs-devel] [RFC PATCH proxmox-backup 2/3] adapt to the new ApiHandler variants Dominik Csapak
2022-02-17  9:40 ` [pbs-devel] [RFC PATCH proxmox-backup 3/3] api: admin/datastore: enable streaming for some api calls Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4958ba7-26ee-b2b2-95b0-8f797a1982ff@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal