[pbs-devel] [PATCH proxmox-backup] datastore: re-phrase error message when datastore is unavailable

[pbs-devel] [PATCH proxmox-backup] datastore: re-phrase error message when datastore is unavailable

[Shannon Sterz]

the current phrase leads to clumsy log messages such as:

> datastore 'store' is in datastore is being unmounted

this commit re-phrases that too:

> datastore 'store' is unavailable: datastore is being unmounted

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 pbs-datastore/src/datastore.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index adf29f18..33bc1f72 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -218,7 +218,7 @@ impl DataStore {
 
         if let Some(maintenance_mode) = config.get_maintenance_mode() {
             if let Err(error) = maintenance_mode.check(operation) {
-                bail!("datastore '{name}' is in {error}");
+                bail!("datastore '{name}' is unavailable: {error}");
             }
         }
 
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup] datastore: re-phrase error message when datastore is unavailable

[Thomas Lamprecht]

Am 26.11.24 um 14:07 schrieb Shannon Sterz:
> the current phrase leads to clumsy log messages such as:
> 
>> datastore 'store' is in datastore is being unmounted
> 
> this commit re-phrases that too:
> 
>> datastore 'store' is unavailable: datastore is being unmounted
> 
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  pbs-datastore/src/datastore.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel