From: "Laurențiu Leahu-Vlăducu" <l.leahu-vladucu@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] Remove mentioning rustup in README.rst because it's no longer needed
Date: Mon, 16 Dec 2024 11:20:37 +0100 [thread overview]
Message-ID: <c265f826-c01d-437e-867c-d3d6dd4ea90d@proxmox.com> (raw)
In-Reply-To: <D6D0FKU8WH05.3H1AV1KO59JR8@proxmox.com>
On 16.12.24 10:16, Shannon Sterz wrote:
> On Fri Dec 13, 2024 at 2:50 PM CET, Laurențiu Leahu-Vlăducu wrote:
>> Signed-off-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
>> ---
>> README.rst | 9 ---------
>> 1 file changed, 9 deletions(-)
>>
>> diff --git a/README.rst b/README.rst
>> index 0caa9874..1f1a66f2 100644
>> --- a/README.rst
>> +++ b/README.rst
>> @@ -2,15 +2,6 @@
>> Build & Release Notes
>> *********************
>>
>> -``rustup`` Toolchain
>> -====================
>> -
>> -We normally want to build with the ``rustc`` Debian package. To do that
>> -you can set the following ``rustup`` configuration:
>> -
>> - # rustup toolchain link system /usr
>> - # rustup default system
>> -
>
> hm not sure this is "no longer needed". the info is still good if you
> want to use rustup for other reasons, e.g. for testing out nightly
> features etc. so maybe leave this but re-phrase it with "if you want to
> use rustup, you should use the rustc package Debian provides. to do..."
> etc.
Agreed. I was under the impression that this part of README.rst is out
of date, being written at a time where the Rust compiler has just been
added to the Debian packages, where it might have been desirable to use
rustup more (or very) often. But of course, you are right that there are
still good reasons for using rustup, even nowadays. I will send a new
patch that improves the description as you suggested. Thanks!
>
>>
>> Versioning of proxmox helper crates
>> ===================================
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-12-16 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 13:50 Laurențiu Leahu-Vlăducu
2024-12-16 9:16 ` Shannon Sterz
2024-12-16 10:20 ` Laurențiu Leahu-Vlăducu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c265f826-c01d-437e-867c-d3d6dd4ea90d@proxmox.com \
--to=l.leahu-vladucu@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox